Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipelining 4.3 #78111

Draft
wants to merge 16 commits into
base: devel
Choose a base branch
from
Draft

pipelining 4.3 #78111

wants to merge 16 commits into from
+79 −31

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jun 21, 2022 •
edited
Loading

refactor pipelining to make it more responsive to the plugins that support/hinder it

  • pipelining logic has mostly moved to connection plugins so they can decide/override settings.
  • ssh connection plugin now overrides pipelining when a tty is requested.
  • become plugins get new property 'pipelining' to show support or lack there of for the feature.
  • su become plugin class now correctly shows both require_tty and pipelining properties.

code shamelessly copied from #78065

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

connection/become/action plugins

@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 21, 2022
@bcoca
fix name
16085db
@bcoca
moved module condition to action plugin
21d85e5 
  connection shoudl not need to know about module, only action plugin should
@bcoca
update tests
fc7f9cb
@bcoca
more positional derefs
a63e958
@bcoca
seems su requirement for tty was not true
aad1598
@bcoca
no pipe for you
6d1771f 
t# Title: Summary, imperative, start upper case, don't end with a period
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 21, 2022
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jun 23, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 23, 2022
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jun 23, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 23, 2022
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jun 23, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 23, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 23, 2022
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jun 27, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 27, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 27, 2022
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 27, 2022
@bcoca
get option, not dict of option
352c950 
 also remove remote_is_local, not pertinent
@bcoca
restore test
8099575
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Jun 27, 2022
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jun 28, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 28, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 6, 2022
@bcoca bcoca marked this pull request as draft July 15, 2022 21:58
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jul 15, 2022
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 11, 2023
@ansibot ansibot added the feature This issue/PR relates to a feature request. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.14 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @webknjaz @mattclay @ansibot