Skip to content

shell plugin now uses config system fully #78167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

shell plugin now uses config system fully #78167

wants to merge 2 commits into from
+36 −34

Conversation

@bcoca
Copy link
Member

@bcoca bcoca commented Jun 29, 2022

removed 'action plugin hack' that did it's own
inheritance/traversal of environment keywords

this also allows for plugins to expand/define more sources of config

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/shell

@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 29, 2022
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Jun 30, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 30, 2022
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jul 8, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 8, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 16, 2022
@bcoca bcoca marked this pull request as draft August 24, 2022 20:15
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 24, 2022
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 20, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 28, 2022
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 3, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025
bcoca added 2 commits June 4, 2025 12:50
@bcoca
shell plugin now uses config system fully
0612b41 
  removed 'action plugin hack' that did it's own
  inheritance/traversal of environment keywords

  this also allows for plugins to expand/define more sources of config
@bcoca
fix global
0c12d3d
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_pr This PR has not been pushed to for more than one year. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 4, 2025
@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2025

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/action/__init__.py:359:4: bad-docstring-quotes: Bad docstring quotes in method, expected """, given '''
lib/ansible/plugins/shell/__init__.py:91:25: f-string-without-interpolation: Using an f-string that does not have any interpolated variables

The test ansible-test sanity --test mypy [explain] failed with 1 error:

lib/ansible/plugins/action/__init__.py:316:9: call-arg: Too many arguments for "_compute_environment_string"

click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 18, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

affects_2.14 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcoca @ansibot @mattclay @nitzmahone