-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanity tests: ignore shebangs in files/ and templates/ in collection roles and integration test targets #79700
base: devel
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Thanks a lot! :-) |
Anything still missing for a successful review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to look at this further, and take into consideration how it fits in with other sanity tests. If it were to be merged, it should at least be updated so the change only affects collections.
test/lib/ansible_test/_util/controller/sanity/code-smell/shebang.py
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
@mattclay - any further thoughts? There could of course be checks for shebangs in files/templates folders, even enforced by sanity checks, but forcing every shebang in there to be from the list in this sanity test here is imho a clear bug. |
@MarkusTeufelberger I started looking at this, an other similar issues with sanity tests, but I haven't had time to finish. It's still on my list to get back to. |
RC1 for 2.15 is getting closer and closer, it would be really nice to squeeze this one in. |
Feature freeze already passed :( |
Well, it is a bugfix, not a feature I hope. |
This is being handled as a feature request, not a bug fix. It will not be in 2.15. |
@mattclay any chance for 2.16? |
This would be great. The change is not that big and would be nice to make into the next release. |
Still an issue on 2.18 devel. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The branch needs rebasing. |
…gration test targets.
Co-authored-by: Matt Clay <matt@mystile.com>
6280be8
to
32bd431
Compare
@webknjaz done. |
Please add this to 2.18! |
Considering https://forum.ansible.com/t/5719/4 I doubt that anything will happen here :( |
SUMMARY
Fixes #76612.
ISSUE TYPE
COMPONENT NAME
ansible-test shebang sanity test