Skip to content

Sanity tests: ignore shebangs in files/ and templates/ in collection roles and integration test targets#79700

Open
felixfontein wants to merge 2 commits into
ansible:develfrom
felixfontein:shebang-role-files
Open

Sanity tests: ignore shebangs in files/ and templates/ in collection roles and integration test targets#79700
felixfontein wants to merge 2 commits into
ansible:develfrom
felixfontein:shebang-role-files

Conversation

@felixfontein

@felixfontein felixfontein commented Jan 10, 2023

Copy link
Copy Markdown
Contributor
SUMMARY

Fixes #76612.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-test shebang sanity test

@felixfontein felixfontein mentioned this pull request Jan 10, 2023
Closed
1 task
@ansibot ansibot added affects_2.15 feature This issue/PR relates to a feature request. has_issue needs_triage Needs a first human triage before being processed. test This PR relates to tests. labels Jan 10, 2023
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 10, 2023
@MarkusTeufelberger

MarkusTeufelberger commented Jan 10, 2023

Copy link
Copy Markdown

Thanks a lot! :-)

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jan 10, 2023
@mkrizek mkrizek requested a review from mattclay January 10, 2023 15:30
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 18, 2023
@MarkusTeufelberger

MarkusTeufelberger commented Feb 7, 2023

Copy link
Copy Markdown

Anything still missing for a successful review?

mattclay
mattclay requested changes Feb 13, 2023
View reviewed changes

@mattclay mattclay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to look at this further, and take into consideration how it fits in with other sanity tests. If it were to be merged, it should at least be updated so the change only affects collections.

Comment thread test/lib/ansible_test/_util/controller/sanity/code-smell/shebang.py Outdated
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 13, 2023
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed ci_verified Changes made in this PR are causing tests to fail. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 13, 2023
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 21, 2023
@MarkusTeufelberger MarkusTeufelberger mentioned this pull request Mar 7, 2023
Closed
@MarkusTeufelberger

MarkusTeufelberger commented Mar 8, 2023

Copy link
Copy Markdown

@mattclay - any further thoughts? There could of course be checks for shebangs in files/templates folders, even enforced by sanity checks, but forcing every shebang in there to be from the list in this sanity test here is imho a clear bug.

@felixfontein

felixfontein commented Sep 2, 2023

Copy link
Copy Markdown
Contributor Author

@mattclay any chance for 2.16?

@ohdearaugustin

ohdearaugustin commented Jan 29, 2024

Copy link
Copy Markdown

This would be great. The change is not that big and would be nice to make into the next release.

@MarkusTeufelberger

MarkusTeufelberger commented Apr 9, 2024

Copy link
Copy Markdown

Still an issue on 2.18 devel.

@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Apr 9, 2024
@webknjaz

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 9, 2024
@webknjaz

webknjaz commented Apr 10, 2024

Copy link
Copy Markdown
Member

The branch needs rebasing.

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Apr 10, 2024
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Apr 10, 2024
@felixfontein

felixfontein commented Apr 10, 2024

Copy link
Copy Markdown
Contributor Author

@webknjaz done.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 24, 2024
@felixfontein

felixfontein commented May 5, 2024

Copy link
Copy Markdown
Contributor Author

@webknjaz @mattclay any chance of getting this (or something equivalent) merged?

@MarkusTeufelberger

MarkusTeufelberger commented May 19, 2024

Copy link
Copy Markdown

Please add this to 2.18!

@felixfontein

felixfontein commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

Considering https://forum.ansible.com/t/5719/4 I doubt that anything will happen here :(

@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Apr 15, 2025
felixfontein and others added 2 commits March 13, 2026 20:20
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pending_ci and removed stale_pr This PR has not been pushed to for more than one year. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pending_ci labels Mar 13, 2026
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattclay mattclay mattclay requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

affects_2.15 feature This issue/PR relates to a feature request. has_issue stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. test This PR relates to tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shebang code-smell sanity test triggers on files in roles

7 participants

@felixfontein @ansibot @MarkusTeufelberger @mattclay @ohdearaugustin @webknjaz @mkrizek