Skip to content

Controller argspec#79720

Draft
bcoca wants to merge 24 commits intoansible:develfrom
bcoca:controller_argspec
Draft

Controller argspec#79720
bcoca wants to merge 24 commits intoansible:develfrom
bcoca:controller_argspec

Conversation

@bcoca
Copy link
Copy Markdown
Member

@bcoca bcoca commented Jan 11, 2023

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

@bcoca bcoca mentioned this pull request Jan 11, 2023
Closed
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.15 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. labels Jan 11, 2023
@ansibot

This comment was marked as resolved.

Sign in to view
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jan 12, 2023
@bcoca bcoca force-pushed the controller_argspec branch from b9ca8a0 to baca5a5 Compare January 13, 2023 18:48
@felixfontein
Copy link
Copy Markdown
Contributor

felixfontein commented Jan 13, 2023

CC @russoz I'm pretty sure you'll be interested in this :)

@russoz
Copy link
Copy Markdown
Contributor

russoz commented Jan 13, 2023

Oh yeah! Thanks for the heads up! 😁

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 21, 2023
tremble
tremble reviewed Mar 17, 2023
View reviewed changes
Comment thread lib/ansible/module_utils/parsing/docs_to_spec.py Outdated
@bcoca bcoca force-pushed the controller_argspec branch from baca5a5 to 6052c8e Compare April 20, 2023 17:09
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 20, 2023
mattclay
mattclay reviewed Apr 24, 2023
View reviewed changes
Comment thread lib/ansible/module_utils/parsing/docs_to_spec.py Outdated
@ansible ansible deleted a comment from ansibot Apr 24, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 2, 2023
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 26, 2023
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 12, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
@s-hertel s-hertel mentioned this pull request Jan 17, 2024
Open
1 task
@bcoca bcoca mentioned this pull request Jan 25, 2024
Closed
@bcoca bcoca force-pushed the controller_argspec branch from d1955bf to cba8abd Compare January 25, 2024 16:06
@ansible ansible deleted a comment from ansibot Jan 25, 2024
@ansible ansible deleted a comment from ansibot Jan 25, 2024
@bcoca
Copy link
Copy Markdown
Member Author

bcoca commented Jan 25, 2024

cc @briantist

@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 25, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jan 25, 2024
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 25, 2024
bcoca and others added 22 commits November 13, 2025 08:04
@bcoca
move so modules can use
8802d6b
@bcoca
refining
74aeebd
@bcoca
move module finding to it's own function
3e99025
@bcoca
added TODO to the meat of it
9756e7c
@bcoca
add validation parts
33c9971
@bcoca
update cright
582a97b
@bcoca
fix deprecation passthrough
beb967e
@bcoca @mattclay
Update lib/ansible/module_utils/parsing/docs_to_spec.py
750a3fd 
Co-authored-by: Matt Clay <matt@mystile.com>
@bcoca
todo or not todo
2c6412b
@bcoca
avoid noise
71ad5c6
@bcoca
fix imporst
a53fe03
@bcoca
clog
397fb1f
@bcoca
s
7823f80
@bcoca
fix invocation
f468802
@bcoca @russoz
Apply suggestions from code review
027e8c3 
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@bcoca
fix to standards
84175af
@bcoca
relocate docs
848f6f8
@bcoca
st it
a3c4d97
@bcoca
sldfk
694d589
@bcoca
setup generic invocation
f3028d5 
todo:
   - needs to handle no_log, once it has argspec
   - update test to user friendly message
   - update module_utils/basic.cs to avoid creating by default and adjust msg
@bcoca
lint
c9daa81
@bcoca
typed
2027a46
@bcoca bcoca force-pushed the controller_argspec branch from b3dbf11 to 2027a46 Compare November 13, 2025 13:05
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 13, 2025
@ansibot
Copy link
Copy Markdown
Contributor

ansibot commented Nov 13, 2025

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

lib/ansible/module_utils/parsing/docs_to_spec.py:66:0: ansible-bad-import-from: Import string_types from the Python standard library equivalent instead of ansible.module_utils.six
lib/ansible/plugins/action/__init__.py:348:19: undefined-variable: Undefined variable 'leaf_module_name'
lib/ansible/plugins/action/__init__.py:349:24: undefined-variable: Undefined variable 'collection_name'
lib/ansible/plugins/action/__init__.py:350:65: undefined-variable: Undefined variable 'leaf_module_name'
lib/ansible/plugins/action/__init__.py:351:21: undefined-variable: Undefined variable 'leaf_module_name'
lib/ansible/plugins/action/__init__.py:351:60: undefined-variable: Undefined variable 'collection_name'
lib/ansible/plugins/action/__init__.py:352:61: undefined-variable: Undefined variable 'leaf_module_name'

The test ansible-test sanity --test mypy [explain] failed with 6 errors:

lib/ansible/plugins/action/__init__.py:348:20: name-defined: Name "leaf_module_name" is not defined
lib/ansible/plugins/action/__init__.py:349:25: name-defined: Name "collection_name" is not defined
lib/ansible/plugins/action/__init__.py:350:66: name-defined: Name "leaf_module_name" is not defined
lib/ansible/plugins/action/__init__.py:351:22: name-defined: Name "leaf_module_name" is not defined
lib/ansible/plugins/action/__init__.py:351:61: name-defined: Name "collection_name" is not defined
lib/ansible/plugins/action/__init__.py:352:62: name-defined: Name "leaf_module_name" is not defined

click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 27, 2025
@bcoca bcoca mentioned this pull request Mar 2, 2026
Open
1 task
@s-hertel s-hertel mentioned this pull request Mar 25, 2026
Open
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattclay mattclay mattclay left review comments

+2 more reviewers

@russoz russoz russoz left review comments

@tremble tremble tremble left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects_2.15 feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bcoca @ansibot @felixfontein @russoz @tremble @mattclay @webknjaz @jborean93