Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure var_options is pre-templated for reset_connection #80085

Closed
wants to merge 1 commit into from

Conversation

sivel
Copy link
Member

@sivel sivel commented Feb 23, 2023

SUMMARY

Make sure var_options is pre-templated for reset_connection

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/strategy/init.py

ADDITIONAL INFORMATION

Effectively duplicated from

# grab list of usable vars for this plugin
option_vars = C.config.get_plugin_vars('connection', self._connection._load_name)
varnames.extend(option_vars)
# create dict of 'templated vars'
options = {'_extras': {}}
for k in option_vars:
if k in variables:
options[k] = templar.template(variables[k])

TODO:

  • Still missing allow_extras
  • DRY?

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.15 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch labels Feb 23, 2023
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Feb 28, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 8, 2023
@sivel
Copy link
Member Author

sivel commented Feb 20, 2024

Potential fix for #79755

@webknjaz
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 22, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 6, 2024
@s-hertel
Copy link
Contributor

s-hertel commented Dec 5, 2024

Fixed in #84240 by moving the TE logic to shared code

@s-hertel s-hertel closed this Dec 5, 2024
@ansible ansible locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.15 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants