unarchive - respect symlinks in archives

[TheJJ]

this patch fixes the extraction if symlinks are present in an archive but the symlinks don't exist in the target filesystem.

tar reports this with:

/bin/tar: $filename: Warning: Cannot readlink: No such file or directory

previously, this was not matched against, hence the re-extraction was not triggered, although needed.

additionally, setting permissions on that file later fails, leading to errors like: Unexpected error when accessing exploded file: [Errno 2] No such file or directory: b'/path/to/$filename'

  File "payload.zip/ansible/modules/unarchive.py", line 901, in main
  File "payload.zip/ansible/module_utils/basic.py", line 1417, in set_fs_attributes_if_different
    file_args['path'], file_args['owner'], changed, diff, expand
  File "payload.zip/ansible/module_utils/basic.py", line 1058, in set_owner_if_different
    orig_uid, orig_gid = self.user_and_group(b_path, expand)
  File "payload.zip/ansible/module_utils/basic.py", line 952, in user_and_group
    st = os.lstat(b_path)

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

unarchive module

[webknjaz]

The PR needs rebasing for the CI to pick it up.

[TheJJ]

I've rebased. Please merge? :) @webknjaz

[webknjaz]

Looks like there's a needs_verified label, meaning there's no reproducer and somebody from the core needs to attempt triggering this manually. Note that many folks are on vacation until the end of the year. But I'd recommend adding an integration test demonstrating the mentioned behavior that would prove that it works and would be a regression test long-term.