Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

become plugins, use shlex quote instead of manual #80146

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

become plugins, use shlex quote instead of manual #80146

wants to merge 6 commits into from
+35 −8

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 6, 2023

Affects sudo and su in core

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

become/sudo
become/su

@ansibot ansibot added affects_2.15 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 6, 2023
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Mar 7, 2023
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Mar 10, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 18, 2023
@jborean93
Copy link
Contributor

@bcoca are you still wanting to pursue this, were there any blockers or issues you can across?

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 27, 2023
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jul 27, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 10, 2023
@webknjaz
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 22, 2024
@webknjaz webknjaz mentioned this pull request Nov 23, 2024
Open
@webknjaz
Copy link
Member

This is another case of a PR requiring a rebase to run the CI. It's 817 commits behind devel but the CI only fetches the last 500. I've made a fix for ansible-test that will address this in a more sustainable way: #84375.

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Nov 25, 2024
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 2, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivel sivel sivel left review comments

Assignees
No one assigned
Labels
affects_2.17 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bcoca @jborean93 @webknjaz @sivel @mkrizek @ansibot @s-hertel