Skip to content

get_url - support tabs in checksum file #80365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

get_url - support tabs in checksum file #80365

wants to merge 1 commit into from

Conversation

Normo
Copy link
Contributor

@Normo Normo commented Mar 30, 2023

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.15 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch labels Mar 30, 2023
@Normo Normo force-pushed the get_url-checksum-file-tab-char branch 5 times, most recently from 79dadba to 825ea02 Compare March 30, 2023 12:58
get_url - support tabs in checksum file
a9f6cc1 
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
@Normo Normo force-pushed the get_url-checksum-file-tab-char branch from 825ea02 to a9f6cc1 Compare March 30, 2023 13:02
@mattclay mattclay added ci_verified Changes made in this PR are causing tests to fail. and removed needs_triage Needs a first human triage before being processed. labels Mar 30, 2023
@sivel sivel self-requested a review March 30, 2023 19:23
@sivel
Copy link
Member

sivel commented Mar 30, 2023

Can you point to documentation or a spec referencing a checksum format that uses tabs?

Aside from the functionality for the file to contain a checksum only, the code we have is designed around the format described by GNU core utils:

For each file, ‘md5sum’ outputs by default, the MD5 checksum, a space, a flag indicating binary or text input mode, and the file name. Binary mode is indicated with ‘*’, text mode with ‘ ’ (space). Binary mode is the default on systems where it’s significant, otherwise text mode is the default. The cksum command always uses binary mode and a ‘ ’ (space) flag.

As such, the format is basically represented like one of the following:

a97e6837f60cec6da4491bab387296bbcd72bdba  27617.txt
a97e6837f60cec6da4491bab387296bbcd72bdba *71420.txt

The format you describe using tabs is not known to me to be any form of standard.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 7, 2023
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Jul 4, 2023
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. feature This issue/PR relates to a feature request. test This PR relates to tests. labels Jul 12, 2023
@webknjaz
Copy link
Member

webknjaz commented Jun 6, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jun 6, 2024
@webknjaz
Copy link
Member

webknjaz commented Jun 6, 2024

This needs to be rebased.

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 6, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 20, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 17, 2025
@Akasurde Akasurde added the needs_info This issue requires further information. Please answer any outstanding questions. label Jan 23, 2025
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025
@ansibot
Copy link
Contributor

ansibot commented Feb 11, 2025

@Normo This PR is waiting for your response. Please respond or the PR will be closed.

click here for bot help

@Normo Normo closed this Feb 12, 2025
@ansible ansible locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.15 bug This issue/PR relates to a bug. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Normo @sivel @webknjaz @ansibot @Akasurde @mattclay