priority based post validation #80394

bcoca · 2023-04-04T16:15:07Z

move to priority based post validation and avoid 'custom' value templating

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME

playbooks

ansibot · 2023-04-04T17:20:23Z

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/root/.ansible/test/venv/sanity.package-data/3.11/75a210bb/bin/python /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 411, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 388, in main
    sdist_path = create_sdist(tmp_dir)
                 ^^^^^^^^^^^^^^^^^^^^^
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 193, in create_sdist
    raise Exception('make snapshot failed:\n%s' % stderr)
Exception: make snapshot failed:
warning: no previously-included files found matching 'docs/docsite/rst_warnings'
warning: no previously-included files matching '*' found under directory 'docs/docsite/_build'
warning: no previously-included files matching '*.pyc' found under directory 'docs/docsite/_extensions'
warning: no previously-included files matching '*.pyo' found under directory 'docs/docsite/_extensions'
warning: no files found matching '*.ps1' under directory 'lib/ansible/modules/windows'
warning: no files found matching '*.yml' under directory 'lib/ansible/modules'
warning: no files found matching 'validate-modules' under directory 'test/lib/ansible_test/_util/controller/sanity/validate-modules'
Traceback (most recent call last):
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/hacking/build-ansible.py", line 130, in <module>
    main()
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/hacking/build-ansible.py", line 119, in main
    retval = command.main(args)
             ^^^^^^^^^^^^^^^^^^
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 119, in opts_docs
    cli_klass = getattr(__import__("ansible.cli.%s" % cli_module_name,
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/lib/ansible/cli/adhoc.py", line 16, in <module>
    from ansible.executor.task_queue_manager import TaskQueueManager
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/lib/ansible/executor/task_queue_manager.py", line 33, in <module>
    from ansible.executor.play_iterator import PlayIterator
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/lib/ansible/executor/play_iterator.py", line 29, in <module>
    from ansible.playbook.block import Block
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/lib/ansible/playbook/__init__.py", line 27, in <module>
    from ansible.playbook.play import Play
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/lib/ansible/playbook/play.py", line 34, in <module>
    from ansible.playbook.task import Task
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/lib/ansible/playbook/task.py", line 35, in <module>
    from ansible.playbook.loop_control import LoopControl
  File "/tmp/.tmp-ansible-pep517-8c0qskwx/src/lib/ansible/playbook/loop_control.py", line 30
    label = NonInheritableFieldAttribute(isa='string',j priority=70)
                                                      ^^^^^^^^^^
SyntaxError: invalid syntax. Perhaps you forgot a comma?
Traceback (most recent call last):
  File "/root/.ansible/test/venv/sanity.package-data/3.11/75a210bb/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
    main()
  File "/root/.ansible/test/venv/sanity.package-data/3.11/75a210bb/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 335, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.ansible/test/venv/sanity.package-data/3.11/75a210bb/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 304, in build_sdist
    return backend.build_sdist(sdist_directory, config_settings)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpj0o7hftz/packaging/pep517_backend/_backend.py", line 127, in build_sdist
    for rst_in in _generate_rst_in_templates():
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpj0o7hftz/packaging/pep517_backend/_backend.py", line 87, in _generate_rst_in_templates
    subprocess.check_call(tuple(map(str, generate_man_cmd)))
  File "/usr/lib/python3.11/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '('/root/.ansible/test/venv/sanity.package-data/3.11/75a210bb/bin/python', 'hacking/build-ansible.py', 'generate-man', '--template-file=docs/templates/man.j2', '--output-dir=docs/man/man1/', '--output-format=man', 'lib/ansible/cli/__init__.py', 'lib/ansible/cli/adhoc.py', 'lib/ansible/cli/config.py', 'lib/ansible/cli/console.py', 'lib/ansible/cli/doc.py', 'lib/ansible/cli/galaxy.py', 'lib/ansible/cli/inventory.py', 'lib/ansible/cli/playbook.py', 'lib/ansible/cli/pull.py', 'lib/ansible/cli/vault.py')' returned non-zero exit status 1.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/root/.ansible/test/venv/sanity.docs-build/3.11/37890c81/bin/python /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make core_singlehtmldocs' failed with status code: 2
--> Standard Output
Creating symlinks in core_structure
ln -sf ../rst/core_index.rst rst/index.rst
ln -sf ../dev_guide/core_index.rst rst/dev_guide/index.rst
ln -sf ../sphinx_conf/core_conf.py rst/conf.py
../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/  ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/  ../../lib/ansible/config/base.yml
mkdir -p rst/cli
../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst  ../../lib/ansible/cli/*.py
--> Standard Error
Traceback (most recent call last):
  File "/root/ansible/docs/docsite/../../hacking/build-ansible.py", line 130, in <module>
    main()
  File "/root/ansible/docs/docsite/../../hacking/build-ansible.py", line 119, in main
    retval = command.main(args)
             ^^^^^^^^^^^^^^^^^^
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 119, in opts_docs
    cli_klass = getattr(__import__("ansible.cli.%s" % cli_module_name,
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/ansible/lib/ansible/cli/adhoc.py", line 16, in <module>
    from ansible.executor.task_queue_manager import TaskQueueManager
  File "/root/ansible/lib/ansible/executor/task_queue_manager.py", line 33, in <module>
    from ansible.executor.play_iterator import PlayIterator
  File "/root/ansible/lib/ansible/executor/play_iterator.py", line 29, in <module>
    from ansible.playbook.block import Block
  File "/root/ansible/lib/ansible/playbook/__init__.py", line 27, in <module>
    from ansible.playbook.play import Play
  File "/root/ansible/lib/ansible/playbook/play.py", line 34, in <module>
    from ansible.playbook.task import Task
  File "/root/ansible/lib/ansible/playbook/task.py", line 35, in <module>
    from ansible.playbook.loop_control import LoopControl
  File "/root/ansible/lib/ansible/playbook/loop_control.py", line 30
    label = NonInheritableFieldAttribute(isa='string',j priority=70)
                                                      ^^^^^^^^^^
SyntaxError: invalid syntax. Perhaps you forgot a comma?
make: *** [Makefile:201: cli] Error 1

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -l --json -t filter ansible.builtin" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/bin/ansible-doc", line 27, in <module>
    from ansible.collections.list import list_collection_dirs
  File "/root/ansible/lib/ansible/collections/list.py", line 10, in <module>
    from ansible.cli.galaxy import with_collection_artifacts_manager
  File "/root/ansible/lib/ansible/cli/galaxy.py", line 49, in <module>
    from ansible.galaxy.role import GalaxyRole
  File "/root/ansible/lib/ansible/galaxy/role.py", line 42, in <module>
    from ansible.playbook.role.requirement import RoleRequirement
  File "/root/ansible/lib/ansible/playbook/__init__.py", line 27, in <module>
    from ansible.playbook.play import Play
  File "/root/ansible/lib/ansible/playbook/play.py", line 34, in <module>
    from ansible.playbook.task import Task
  File "/root/ansible/lib/ansible/playbook/task.py", line 35, in <module>
    from ansible.playbook.loop_control import LoopControl
  File "/root/ansible/lib/ansible/playbook/loop_control.py", line 30
    label = NonInheritableFieldAttribute(isa='string',j priority=70)
                                                      ^^^^^^^^^^
SyntaxError: invalid syntax. Perhaps you forgot a comma?

The test ansible-test sanity --test import --python 3.9 [explain] failed with 47 errors:

lib/ansible/cli/adhoc.py:16:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/cli/console.py:24:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/cli/doc.py:27:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/cli/galaxy.py:49:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/cli/playbook.py:20:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/cli/scripts/ansible_connection_cli_stub.py:30:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/collections/list.py:10:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/executor/play_iterator.py:29:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/executor/playbook_executor.py:26:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/executor/process/worker.py:30:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/executor/task_executor.py:25:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/executor/task_queue_manager.py:33:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/galaxy/role.py:42:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/__init__.py:27:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/attribute.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/base.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/block.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/collectionsearch.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/conditional.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/delegatable.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/handler.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/handler_task_include.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/helpers.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/included_file.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/loop_control.py:30:57: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/task.py:35:0)
lib/ansible/playbook/notifiable.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/play.py:34:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/play_context.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/playbook_include.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/role/__init__.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/role/definition.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/role/include.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/role/metadata.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/role/requirement.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/role_include.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/taggable.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/task.py:35:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/playbook/task_include.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/action/assert.py:21:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/callback/default.py:25:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/list.py:12:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/strategy/__init__.py:40:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/strategy/debug.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/strategy/free.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/strategy/host_pinned.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/plugins/strategy/linear.py:0:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)
lib/ansible/vars/reserved.py:22:0: traceback: SyntaxError: positional argument follows keyword argument (at lib/ansible/playbook/loop_control.py:30:57)

The test ansible-test sanity --test import --python 3.11 [explain] failed with 47 errors:

lib/ansible/cli/adhoc.py:16:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/console.py:24:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/doc.py:27:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/galaxy.py:49:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/playbook.py:20:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/scripts/ansible_connection_cli_stub.py:30:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/collections/list.py:10:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/play_iterator.py:29:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/playbook_executor.py:26:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/process/worker.py:30:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/task_executor.py:25:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/task_queue_manager.py:33:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/galaxy/role.py:42:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/__init__.py:27:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/attribute.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/base.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/block.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/collectionsearch.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/conditional.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/delegatable.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/handler.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/handler_task_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/helpers.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/included_file.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/loop_control.py:30:55: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/task.py:35:0)
lib/ansible/playbook/notifiable.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/play.py:34:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/play_context.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/playbook_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/__init__.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/definition.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/metadata.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/requirement.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/taggable.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/task.py:35:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/task_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/action/assert.py:21:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/callback/default.py:25:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/list.py:12:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/__init__.py:40:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/debug.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/free.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/host_pinned.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/linear.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/vars/reserved.py:22:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)

The test ansible-test sanity --test import --python 3.10 [explain] failed with 47 errors:

lib/ansible/cli/adhoc.py:16:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/console.py:24:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/doc.py:27:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/galaxy.py:49:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/playbook.py:20:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/cli/scripts/ansible_connection_cli_stub.py:30:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/collections/list.py:10:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/play_iterator.py:29:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/playbook_executor.py:26:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/process/worker.py:30:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/task_executor.py:25:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/executor/task_queue_manager.py:33:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/galaxy/role.py:42:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/__init__.py:27:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/attribute.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/base.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/block.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/collectionsearch.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/conditional.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/delegatable.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/handler.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/handler_task_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/helpers.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/included_file.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/loop_control.py:30:55: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/task.py:35:0)
lib/ansible/playbook/notifiable.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/play.py:34:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/play_context.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/playbook_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/__init__.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/definition.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/metadata.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role/requirement.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/role_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/taggable.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/task.py:35:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/playbook/task_include.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/action/assert.py:21:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/callback/default.py:25:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/list.py:12:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/__init__.py:40:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/debug.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/free.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/host_pinned.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/plugins/strategy/linear.py:0:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)
lib/ansible/vars/reserved.py:22:0: traceback: SyntaxError: invalid syntax. Perhaps you forgot a comma? (at lib/ansible/playbook/loop_control.py:30:55)

The test ansible-test sanity --test compile --python 3.9 [explain] failed with 1 error:

lib/ansible/playbook/loop_control.py:30:57: SyntaxError: label = NonInheritableFieldAttribute(isa='string',j priority=70)

The test ansible-test sanity --test compile --python 3.11 [explain] failed with 1 error:

lib/ansible/playbook/loop_control.py:30:55: SyntaxError: label = NonInheritableFieldAttribute(isa='string',j priority=70)

The test ansible-test sanity --test compile --python 3.10 [explain] failed with 1 error:

lib/ansible/playbook/loop_control.py:30:55: SyntaxError: label = NonInheritableFieldAttribute(isa='string',j priority=70)

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/playbook/loop_control.py:30:55: syntax-error: Parsing failed: 'invalid syntax. Perhaps you forgot a comma? (<unknown>, line 30)'
lib/ansible/playbook/task.py:35:0: syntax-error: Cannot import 'ansible.playbook.loop_control' due to 'invalid syntax. Perhaps you forgot a comma? (<unknown>, line 30)'

click here for bot help

ansibot · 2023-04-04T18:01:49Z

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/playbook/play.py:64:161: E501: line too long (164 > 160 characters)
lib/ansible/playbook/play_context.py:102:47: E241: multiple spaces after ','

click here for bot help

setup templar for auto templating fall back to default (or true for nolog) when boolean fails to template

ansibot · 2023-04-11T15:01:22Z

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/playbook/base.py:546:13: E265: block comment should start with '# '

click here for bot help

ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.16 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Apr 4, 2023

bcoca mentioned this pull request Apr 4, 2023

handle run_once with omit keyword on linear strategy #80382

Closed

bcoca mentioned this pull request Apr 5, 2023

register variable not available during ignore_errors evaluation #80393

Open

1 task

ansibot added the has_issue label Apr 5, 2023

bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2023

s-hertel mentioned this pull request Apr 11, 2023

Validate task attributes with first finalized attrs after loop #80476

Merged

bcoca added 9 commits April 11, 2023 10:05

priority based post validation

ce1e2e4

rearranged to count for previous loop interrupts

130daef

add 'recursive object post validation'

412d793

add finalized to attributes

e8802b1

fix typoe

01a7d16

fix typoes

beb6b85

only if it maches

ea99e1e

move to getter for FA access

b2ebcbb

setup templar for auto templating fall back to default (or true for nolog) when boolean fails to template

PEEEPEEEEEE!#

57e4fbe

bcoca force-pushed the fix_pv branch from 5cecae1 to 57e4fbe Compare April 11, 2023 14:08

no final, breaks loops#

c414ccd

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 19, 2023

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. feature This issue/PR relates to a feature request. and removed has_issue labels Jul 12, 2023

ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 22, 2023

ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023

ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025

bcoca closed this Feb 18, 2025

bcoca deleted the fix_pv branch February 18, 2025 17:13

ansible locked and limited conversation to collaborators Mar 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

priority based post validation #80394

priority based post validation #80394

bcoca commented Apr 4, 2023

ansibot commented Apr 4, 2023

ansibot commented Apr 4, 2023

ansibot commented Apr 11, 2023

priority based post validation #80394

priority based post validation #80394

Conversation

bcoca commented Apr 4, 2023

ISSUE TYPE

COMPONENT NAME

ansibot commented Apr 4, 2023

ansibot commented Apr 4, 2023

ansibot commented Apr 11, 2023