-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor loading of vars_files to simplify and properly implement expectations #80505
Open
sivel
wants to merge
1
commit into
ansible:devel
Choose a base branch
from
sivel:issue/80483
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few things i've been thinking for this feature:
Once deprecation periods are over this becomes a very simple feature we should only call 1/play |
s-hertel
reviewed
Apr 12, 2023
s-hertel
approved these changes
Apr 17, 2023
1 task
sivel
commented
Aug 3, 2023
bcoca
approved these changes
Aug 16, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects_2.16
bug
This issue/PR relates to a bug.
data_tagging
has_issue
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
stale_review
Updates were made after the last review and the last review is more than 7 days old.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Refactor loading of vars_files to simplify and properly implement expectations. Fixes #80483
ISSUE TYPE
COMPONENT NAME
lib/ansible/vars/manager.py
ADDITIONAL INFORMATION
Reviewers will almost certainly want to view the changes ignoring whitespace: https://github.com/ansible/ansible/pull/80505/files?w=1