fixes static 'roles:' with play context

[bcoca]

fixes #79373

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

core

[nitzmahone]

I haven't actually debugged through the reproducer, but at a glance this doesn't feel right. I suspect maybe this is running afoul of the "default collection" stuff that was added to make only the first playbook we run from inside a collection plug that collection into the collections short-name resolution path if it's not otherwise specified. I know we tested the behavior with multiple playbooks on the CLI, but I don't remember how much testing we did with various corner cases of import_playbook and that stuff. This predated the actual ability to run playbooks as a collection-addressable resource- it was mainly added as a workaround to having to rewrite all the integration tests for content that was pushed out to collections.

If it's the default collection stuff, we probably just need to resample that every time we start a new playbook- IIRC that would match the behavior of invoking multiple playbooks from the CLI when the first one lived under a collection.

[bcoca]

not just a playbook, every time you reference a role from another collection, you end up with N contexts, playbook and role(s), imho the latest should have priority, but the former ones should be present also.

[webknjaz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[webknjaz]

@mattclay @sivel this is an example PR that #84375 / #84402 would've helped with.