Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Python 3.12 support to ansible-test #80834

Merged
merged 9 commits into from Jul 21, 2023
Merged

add Python 3.12 support to ansible-test #80834

merged 9 commits into from Jul 21, 2023

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented May 17, 2023 •
edited

SUMMARY

add Python 3.12 as a supported ansible-test controller Python version

update test containers

add Python 3.12 to the text matrix

ISSUE TYPE
  • Feature Pull Request

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.16 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch test This PR relates to tests. labels May 17, 2023
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label May 18, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 27, 2023
@gotmax23 gotmax23 mentioned this pull request Jun 14, 2023
Closed
2 tasks
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 14, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 22, 2023
@ansibot ansibot removed small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 7, 2023
@s-hertel s-hertel mentioned this pull request Jul 7, 2023
Merged
@s-hertel s-hertel mentioned this pull request Jul 7, 2023
Closed
@s-hertel s-hertel force-pushed the python-3.12 branch 2 times, most recently from a5718bf to 7bf7d44 Compare July 10, 2023 17:23
@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed has_issue labels Jul 12, 2023
@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot

This comment was marked as outdated.

Sign in to view
@s-hertel s-hertel force-pushed the python-3.12 branch 2 times, most recently from 2579a22 to bc4893d Compare July 19, 2023 18:32
@s-hertel s-hertel mentioned this pull request Jul 20, 2023
Merged
@s-hertel
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@s-hertel s-hertel marked this pull request as draft July 20, 2023 20:35
@s-hertel
* Update unit test for using the Python 2 collection loader path with
fec76c7 
Python 3.

Skip the existing test on Python 3.12, since find_module is removed.

Suppress the pre-existing deprecation warnings using the Python 2
codepath with Python 3.

Add a test for Python >= 3.12, which doesn't call find_module.

* Ignore sanity test errors on systems without libselinux present.
@s-hertel s-hertel mentioned this pull request Jul 20, 2023
Merged
@ansibot ansibot removed the module This issue/PR relates to a module. label Jul 20, 2023
@s-hertel s-hertel marked this pull request as ready for review July 20, 2023 22:13
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 20, 2023
@s-hertel
Copy link
Contributor Author

@mattclay I think this is ready to merge. I separated the datetime stuff into #81323 since it could probably be backported.

@s-hertel s-hertel requested a review from mattclay July 21, 2023 14:58
@mattclay mattclay merged commit 48dfe8e into ansible:devel Jul 21, 2023
81 checks passed
s-hertel added a commit to s-hertel/ansible that referenced this pull request Jul 21, 2023
@s-hertel
Update ansible-test container versions to bring the test venvs in syn…
cb296e4 
…c with ansible#80834

ci_complete
@s-hertel s-hertel mentioned this pull request Jul 21, 2023
Merged
@ansible ansible locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz left review comments

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.16 feature This issue/PR relates to a feature request. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s-hertel @ansibot @mattclay @webknjaz