Skip to content

flush stdout after sending prompt and individual loop item results #81158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

flush stdout after sending prompt and individual loop item results #81158

wants to merge 2 commits into from
+82 −18

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Fixes #79662
Fixes #81155

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

prompting
loops

@s-hertel s-hertel requested a review from nitzmahone June 30, 2023 00:34
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.16 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Jun 30, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 11, 2023
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2023
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Aug 9, 2023
@s-hertel s-hertel force-pushed the flush_after_prompt branch from 3d4376c to a977cad Compare August 9, 2023 14:35
@s-hertel s-hertel marked this pull request as ready for review August 9, 2023 14:36
@s-hertel s-hertel force-pushed the flush_after_prompt branch 2 times, most recently from 5250550 to 5e4416e Compare August 9, 2023 14:47
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 9, 2023
nitzmahone
nitzmahone approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change checks out and LGTM- see private discussion for a faster/simpler approach to the integration test.

@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels Aug 9, 2023
nitzmahone
nitzmahone reviewed Aug 9, 2023
View reviewed changes
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 9, 2023
@s-hertel s-hertel force-pushed the flush_after_prompt branch 3 times, most recently from 882ec05 to 809c9b6 Compare August 10, 2023 15:23
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 10, 2023
@s-hertel

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@s-hertel

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@s-hertel

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 24, 2023
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 7, 2023
@s-hertel s-hertel force-pushed the flush_after_prompt branch from 4b8d993 to c39266a Compare April 30, 2024 14:23
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 30, 2024
@s-hertel s-hertel force-pushed the flush_after_prompt branch from c39266a to 46e7e1c Compare April 30, 2024 14:47
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 30, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 14, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 13, 2024
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 4, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 18, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 3, 2025
s-hertel and others added 2 commits April 14, 2025 16:42
@s-hertel
flush after prompting and individual loop items
743589c 
ci_complete
@s-hertel @nitzmahone
Add a test case for loop item display
5c44b62 
Use test_utils timeout script for compatibility on different platforms

Reduce test duration and redistribute timeout to try to avoid race
condition

Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
@s-hertel s-hertel force-pushed the flush_after_prompt branch from 28e6736 to 5c44b62 Compare April 14, 2025 20:46
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 14, 2025
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.16 bug This issue/PR relates to a bug. has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
4 participants
@s-hertel @bcoca @nitzmahone @ansibot