Skip to content

flush stdout after sending prompt and individual loop item results - #81158

Open
s-hertel wants to merge 1 commit into
ansible:develfrom
s-hertel:flush_after_prompt
Open

s-hertel wants to merge 1 commit into
ansible:develfrom
s-hertel:flush_after_prompt

Conversation

@s-hertel

Copy link
Copy Markdown
Contributor
SUMMARY

Fixes #79662
Fixes #81155

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

prompting
loops

@s-hertel
s-hertel requested a review from nitzmahone June 30, 2023 00:34
@ansibot ansibot added WIP affects_2.16 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Jun 30, 2023
bcoca
bcoca previously approved these changes Jul 3, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 11, 2023
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2023
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Aug 9, 2023
@s-hertel
s-hertel force-pushed the flush_after_prompt branch from 3d4376c to a977cad Compare August 9, 2023 14:35
@s-hertel
s-hertel marked this pull request as ready for review August 9, 2023 14:36
@s-hertel
s-hertel force-pushed the flush_after_prompt branch 2 times, most recently from 5250550 to 5e4416e Compare August 9, 2023 14:47
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 9, 2023
nitzmahone
nitzmahone previously approved these changes Aug 9, 2023

@nitzmahone nitzmahone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change checks out and LGTM- see private discussion for a faster/simpler approach to the integration test.

@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels Aug 9, 2023
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 9, 2023
@s-hertel
s-hertel force-pushed the flush_after_prompt branch 3 times, most recently from 882ec05 to 809c9b6 Compare August 10, 2023 15:23
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 10, 2023
@s-hertel

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@s-hertel

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@s-hertel

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 13, 2024
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 4, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 18, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 3, 2025
@s-hertel
s-hertel force-pushed the flush_after_prompt branch from 28e6736 to 5c44b62 Compare April 14, 2025 20:46
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 14, 2025
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 29, 2025
@s-hertel
s-hertel force-pushed the flush_after_prompt branch from 5c44b62 to bdf6523 Compare March 16, 2026 15:46
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 16, 2026
@ansibot

This comment was marked as resolved.

Add a test case for loop item display

Use test_utils timeout script for compatibility on different platforms

Reduce test duration and redistribute timeout to try to avoid race
condition

ci_complete

Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
@s-hertel
s-hertel force-pushed the flush_after_prompt branch from bdf6523 to 4656ed5 Compare March 16, 2026 16:54
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 25, 2026
@s-hertel
s-hertel dismissed stale reviews from nitzmahone and bcoca via 4656ed5 June 9, 2026 16:16
@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jun 9, 2026
@ansibot ansibot removed the WIP label Jun 24, 2026
@webknjaz

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 24, 2026
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jun 25, 2026

rm -f out.txt && touch out.txt

python ../test_utils/scripts/timeout.py -- 10 'ansible-playbook test_loop_item_display.yml "$@" >> out.txt' &

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

06:21 FileNotFoundError: [Errno 2] No such file or directory: 'ansible-playbook test_loop_item_display.yml "$@" >> out.txt'

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects_2.16 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.

Projects

None yet

5 participants