Skip to content

module_environment, new keyword to pass environment variables only to modules - #81320

Draft
bcoca wants to merge 2 commits into
ansible:develfrom
bcoca:hidden_env
Draft

module_environment, new keyword to pass environment variables only to modules#81320
bcoca wants to merge 2 commits into
ansible:develfrom
bcoca:hidden_env

Conversation

@bcoca

@bcoca bcoca commented Jul 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

TODO:

  • Wait for data tagging to see if we can do a new implementation w/o having to create a new keyword
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module execution

@ansibot ansibot added needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 20, 2023
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 25, 2023
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jul 25, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 1, 2023
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 17, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
@ansible ansible deleted a comment from ansibot May 29, 2024
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 29, 2024
webknjaz
webknjaz reviewed May 30, 2024
View reviewed changes
Comment thread lib/ansible/module_utils/common/parameters.py Outdated
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label May 30, 2024
@ansible ansible deleted a comment from ansibot May 30, 2024
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed ci_verified Changes made in this PR are causing tests to fail. labels May 30, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label May 31, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 7, 2024
@ansible ansible deleted a comment from ansibot Dec 3, 2024
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 4, 2024
@bcoca bcoca changed the title Pass environment variables privately to modules module_environment, new keyword to pass environment variables only to modules Dec 4, 2024
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 4, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 19, 2024
@webknjaz

webknjaz commented Jan 21, 2025

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 21, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@webknjaz webknjaz removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 21, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jan 22, 2025
@webknjaz

webknjaz commented Jan 22, 2025

Copy link
Copy Markdown
Member

@bcoca unimportant_ci?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 4, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 7, 2025
@bcoca @webknjaz
Pass environment variables privately to modules
79b2b00 
add POSIX note as windows works very diff

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 21, 2025
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 21, 2025
@ansibot

ansibot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/executor/module_common.py:1329:19: undefined-variable: Undefined variable 'module_env'

The test ansible-test sanity --test mypy [explain] failed with 2 errors:

lib/ansible/executor/module_common.py:1329:20: name-defined: Name "module_env" is not defined
lib/ansible/plugins/action/__init__.py:106:9: var-annotated: Need type annotation for "__internal_env" (hint: "__internal_env: dict[<type>, <type>] = ...")

click here for bot help

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Oct 21, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 4, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci_verified Changes made in this PR are causing tests to fail. data_tagging feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcoca @webknjaz @ansibot @mkrizek