Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module_environment, new keyword to pass environment variables only to modules #81320

Draft
wants to merge 24 commits into
base: devel
Choose a base branch
from
Draft

module_environment, new keyword to pass environment variables only to modules #81320

wants to merge 24 commits into from
+29 −7

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 20, 2023 •
edited
Loading

TODO:

  • Wait for data tagging to see if we can do a new implementation w/o having to create a new keyword
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module execution

@ansibot ansibot added needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 20, 2023
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 25, 2023
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jul 25, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 1, 2023
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 17, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
@ansible ansible deleted a comment from ansibot May 29, 2024
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 29, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label May 30, 2024
@ansible ansible deleted a comment from ansibot May 30, 2024
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed ci_verified Changes made in this PR are causing tests to fail. labels May 30, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label May 31, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 7, 2024
@ansible ansible deleted a comment from ansibot Dec 3, 2024
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 4, 2024
@bcoca bcoca changed the title Pass environment variables privately to modules module_environment, new keyword to pass environment variables only to modules Dec 4, 2024
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 4, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 19, 2024
@webknjaz webknjaz removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 21, 2025
bcoca and others added 23 commits January 21, 2025 13:20
@bcoca
Pass environment variables privately to modules
a9ff660
@bcoca
relocate
704c76c
@bcoca
clog
42f6b55
@bcoca
renamed to module_env, no privacy promisses
48b0620
@bcoca
made it a keyword
c1a6583
@bcoca @webknjaz
Update lib/ansible/module_utils/common/parameters.py
4dfab42 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@bcoca
dont mock module_env, set to dict
d93858a
@bcoca
match names
cc218a1
@bcoca
really
8d77340
@bcoca
its a list of dicts
9f8d0e7
@bcoca
initialize to list
0a6a4fb
@bcoca
better inits and names
38b856a
@bcoca
fixdoc
09cc831
@bcoca
mnissed one
34cf76c
@bcoca
updated clog
2445a8c
@bcoca
allow pwshll modules to ignore module_env arg
31f6c03
@bcoca
ignore empty module_env
d6bc4f7
@bcoca
spell it out
d4e7027
@bcoca
missed one!
5811411
@bcoca
changed from list of dicts to dict
8bbd8b9 
removes the ambiguity we have in environment
@bcoca
fix for pswhl and replacer
f00d2ab
@bcoca
fix
9d8439a
@bcoca
fix old style dumping env
ccfb5cd
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jan 22, 2025
@webknjaz
Copy link
Member

@bcoca unimportant_ci?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
ci_verified Changes made in this PR are causing tests to fail. data_tagging feature This issue/PR relates to a feature request. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcoca @webknjaz @mkrizek @ansibot