Skip to content

Add install_suggests in apt module #81594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Add install_suggests in apt module #81594

wants to merge 3 commits into from
+67 −4

Conversation

kencx
Copy link

@kencx kencx commented Aug 30, 2023

SUMMARY

This PR adds install_suggests to the apt module to allow installing suggested packages.

Fixes #81173

ISSUE TYPE
  • Feature Pull Request

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. has_issue ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 30, 2023
@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2023

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/apt.py:0:0: option-incorrect-version-added: version_added for new option (install_suggests) should be '2.16'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Aug 30, 2023
bcoca
bcoca requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@bcoca bcoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a changelog and tests

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 31, 2023
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 31, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 7, 2023
@Akasurde
Copy link
Member

@kencx Are you still working on this change? Thanks in advance.

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 2, 2024
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 18, 2024
@Akasurde Akasurde requested a review from bcoca April 18, 2024 04:18
@Akasurde Akasurde enabled auto-merge (squash) April 18, 2024 13:49
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 2, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 25, 2024
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoca bcoca Awaiting requested review from bcoca

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year. stale_review Updates were made after the last review and the last review is more than 7 days old.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install suggested packages with apt module
4 participants
@kencx @ansibot @Akasurde @bcoca