constructed inventory, allow adding variables directly, including ansible_group_priority

[bcoca]

implementing #76788

ISSUE TYPE

• Feature Pull Request

[acziryak-everhealth]

I'm waiting on this to get merged and released to enable the inventory setup that I've architected. Anything I can do to get this pushed through?

[bcoca]

Time, which I don't have much of.

I'm fine if you want to take over this PR and complete it, it at least needs tests. The other thing i was mulling over is making priority templatable or not and injecting keyed_group_name as a variable

[acziryak-everhealth]

I took a stab at fixing an error I ran into, and adding tests.

I have the changes here in a fork that I made: 0a6fa06

I'm not sure what the workflow would be to get this into the PR. I guess I could open a PR against the branch in your repo, which when merged would reflect in this PR? IDK, I just don't wanna mess anything up workflow-wise for you.

I mean, I haven't ever even contributed code to Ansible before, so I don't know what a typical workflow looks like, much less whatever's going on here.

---

Re: the templating of the priority variable: I don't think that would address either mine or the original issue, since we were both utilizing it to set a static priority number. Adding that wouldn't solve any issue that's currently been brought up.

---

I'm definitely lost at what you mean by "injecting keyed_group_name as a variable", or in what way that might be useful. Do you mean to make it a bool, as in "This group has been created by the keyed_groups functionality"? Or something completely different? Either way, I don't think any additional variable is needed to solve the issues that lead to this PR getting created.

Thanks for all the work that you do, and I hope that whatever I can do on this can save you some time and effort.

[bcoca]

as for workflow, you can add a 'suggested commit' to this PR itself

the templating/keyed_group_name was so you could do the following:

keyed_groups:
  - key: tags
    prefix: tag
    default_value: "running"
    priority: "{{ 10 if 'status' in ansible_keyed_group_name else 50 }}"

assuming tags: stuff, otherstuff, thisstatus, that_status

[acziryak-everhealth]

I wasn't able to find suggested commits on this PR, so I opened bcoca#13 with my changes. If that's not going to work, hopefully we can figure something else out.

[acidtracks]

Hello,
do you have an idea when this pr will be merged please?
I need this to merge some multi environments inventories into one.

Really helpfull thanks by advance

[nitzmahone]

Just a couple typos, otherwise LGTM

[ansibot]

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/plugins/inventory/constructed.py:0:0: option-incorrect-version-added: version_added for new option (group_vars) should be '2.19'. Currently StrictVersion ('2.17')

click here for bot help