Skip to content

Implement a debugging reporter for collection dependency resolver #81693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Sep 13, 2023

SUMMARY

This change adds a dependency resolution reporter for tracing the decisions resolvelib is doing.

ISSUE TYPE
  • Feature Pull Request
ADDITIONAL INFORMATION

@webknjaz webknjaz self-assigned this Sep 13, 2023
@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. labels Sep 13, 2023
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Sep 13, 2023
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. labels Sep 13, 2023
@ansibot

This comment was marked as off-topic.

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Sep 13, 2023
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 14, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 21, 2023
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Dec 28, 2024
@webknjaz

This comment was marked as resolved.

This comment was marked as resolved.

@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jan 21, 2025
@webknjaz

This comment was marked as outdated.

@webknjaz webknjaz added the unimportant_ci This PR does not need to have healthy CI status and should be ignored by the CI infra maintainers. label Jan 21, 2025
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 21, 2025
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 4, 2025
@webknjaz webknjaz moved this from 📑 Ready 👌 to 🗒️ Backlog 📝 in 📅 Procrastinating in public Feb 28, 2025
@webknjaz webknjaz force-pushed the features/galaxy-collection-depresolver-debugging-reporter branch from f9f4590 to ea78360 Compare February 28, 2025 23:25
@ansibot ansibot removed stale_pr This PR has not been pushed to for more than one year. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 28, 2025
@ansibot

This comment was marked as outdated.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 10, 2025
@webknjaz webknjaz force-pushed the features/galaxy-collection-depresolver-debugging-reporter branch from ea78360 to 92502be Compare March 11, 2025 16:00
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 11, 2025
@webknjaz webknjaz marked this pull request as ready for review March 12, 2025 14:59
@webknjaz webknjaz requested review from jborean93 and s-hertel March 12, 2025 15:00
@webknjaz
Copy link
Member Author

@jborean93 @s-hertel so I've experimented with the extending the depresolver troubleshooting capabilities. Plz play with this and let me know what you think...

@webknjaz webknjaz removed the unimportant_ci This PR does not need to have healthy CI status and should be ignored by the CI infra maintainers. label Mar 12, 2025
@webknjaz webknjaz moved this from 🗒️ Backlog 📝 to 🫸In review🫷 in 📅 Procrastinating in public Mar 12, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 19, 2025
Copy link
Contributor

@s-hertel s-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a changelog.

@@ -45,5 +49,6 @@ def build_collection_dependency_resolver(
upgrade=upgrade,
include_signatures=include_signatures,
),
CollectionDependencyReporter(),
CollectionDependencyDebuggingReporter() if C.DEFAULT_DEBUG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a dedicated config for the ansible-galaxy reporter mode, so its easy to add new reporters in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still consult the debug mode along with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.18 feature This issue/PR relates to a feature request. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants