Repository navigation
Conversation
sbettid
marked this pull request as draft
September 30, 2023 10:41
sbettid
marked this pull request as ready for review
September 30, 2023 18:12
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #81751.
The problem resided in the fact that pip list does not show the commit information related with modules installed from VCS, and this could lead to a wrong
changedstatus reported, in case the module is installed again from a different branch or commit that does not change the version.The main idea, as was mentioned also in the issue comments, is to incorporate in the check also the information reported by
pip freeze, since this reports information also on the commit used when installing from VCS.The related integration tests have been added to the existing ones.
ISSUE TYPE
ADDITIONAL INFORMATION
Starting from the following state, obtained using
pip freeze:and installing the module using a different commit (but same version), as follows
the result would currently be:
while, executing again
pip freeze, we would notice the change:After the fix, the execution will correctly report the
changedstatus: