make constant loading dynamic #81947
Draft
+46
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
feature
webknjaz
added
the
ci_verified
ansibot
removed
the
ci_verified
sivel
removed
the
needs_triage
webknjaz
added
the
ci_verified
bcoca
force-pushed
the
dynamic_constant
branch
from
572ad93 to
32da996
Compare
ansibot
removed
the
ci_verified
webknjaz
reviewed
Oct 31, 2023
webknjaz
reviewed
Oct 31, 2023
|
This somehow makes the |
webknjaz
added
the
ci_verified
Well, since this can dynamically create a constant post fork, it is a trade off between generating all constants up front even when we don't need most and recreating a constant we use a lot but only post fork. These constants are basically module level variables we inject. I can see how that can create issues, specially since |
ansibot
removed
the
ci_verified
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
bcoca
force-pushed
the
dynamic_constant
branch
from
4043386 to
47fe713
Compare
ansibot
removed
the
needs_rebase
bcoca
force-pushed
the
dynamic_constant
branch
from
47fe713 to
e0247c0
Compare
ansibot
removed
ci_verified
ansibot
removed
the
ci_verified
webknjaz
added
the
ci_verified
Akasurde
reviewed
Nov 13, 2024
|
|
webknjaz
added
the
ci_verified
ansibot
added
the
stale_ci
|
@webknjaz possibly, in my tests the startup is faster, since it only loads what it needs, but if you end up needing most settings it is slower in the end, why i added a forced dump method for ansible-config which is basically how it works before the patch. I'll check the stdin test to see what is going on. |
bcoca
force-pushed
the
dynamic_constant
branch
from
c257902 to
9f8ffd3
Compare
ansibot
removed
ci_verified
|
/azp run |
|
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
|
/azp run |
webknjaz
removed
the
needs_revision
|
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
bcoca
force-pushed
the
dynamic_constant
branch
from
9f8ffd3 to
578766d
Compare
|
@bcoca another |
webknjaz
added
the
ci_verified
ansibot
added
the
stale_ci
now constants get populated 'on demand' and cached once set We do need to ensure we initalize deps (constants use in templating for other constants)
deprecations for setting sources only appear when settings is used
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
bcoca
force-pushed
the
dynamic_constant
branch
from
578766d to
47371a8
Compare
ansibot
removed
ci_verified
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't load a configuration unless we need it.
Config deprecations/warnings less noisy as they will only trigger for config sources if setting is consumed
ISSUE TYPE