Skip to content

Implement relative path in checksumfile #81967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: devel
Choose a base branch
from
Open

Implement relative path in checksumfile #81967

wants to merge 8 commits into from
+83 −0

Conversation

anmorel
Copy link

@anmorel anmorel commented Oct 13, 2023 •
edited
Loading

SUMMARY

Implement relative path url when checksum file and file isn't at same level.

ISSUE TYPE

Feature Pull Request

ADDITIONAL INFORMATION

By exemple get_url don't work for download file on Debian repository :

- name:  Download OS tar 
  ansible.builtin.get_url:
    url: 'https://deb.debian.org/debian/dists/bullseye/main/installer-amd64/current/images/netboot/netboot.tar.gz'
    dest: '/srv/tftp/images/netboot.tar.gz'
    checksum: 'sha256:https://deb.debian.org/debian/dists/bullseye/main/installer-amd64/current/images/SHA256SUMS'
    mode: '0644'

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. labels Oct 13, 2023
@ansibot
Copy link
Contributor

ansibot commented Oct 13, 2023

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/get_url.py:569:72: E241: multiple spaces after ','

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 13, 2023
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 16, 2023
@anmorel anmorel marked this pull request as draft October 17, 2023 10:02
@anmorel anmorel marked this pull request as ready for review October 17, 2023 10:02
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 17, 2023
bcoca
bcoca requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@bcoca bcoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs a changelog

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 17, 2023
@bcoca bcoca requested a review from sivel October 17, 2023 15:55
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 18, 2023
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels Oct 18, 2023
@anmorel
Copy link
Author

anmorel commented Oct 20, 2023 •
edited
Loading

Hey @bcoca ,
I have something to do ?

@bcoca
Copy link
Member

bcoca commented Oct 20, 2023

@anmorel i just wait for other reviewer

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 26, 2023
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 23, 2024
@anmorel anmorel requested a review from bcoca April 19, 2024 09:25
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 15, 2025
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_pr This PR has not been pushed to for more than one year. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 10, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivel sivel Awaiting requested review from sivel

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmorel @ansibot @bcoca