Skip to content

Implement relative path in checksumfile - #81967

Open
anmorel wants to merge 1 commit into
ansible:develfrom
anmorel:feat_get_url_module_implement_relative_path_in_checksumfile
Open

Implement relative path in checksumfile#81967
anmorel wants to merge 1 commit into
ansible:develfrom
anmorel:feat_get_url_module_implement_relative_path_in_checksumfile

Conversation

@anmorel

@anmorel anmorel commented Oct 13, 2023 •
edited
Loading

Copy link
Copy Markdown
SUMMARY

Implement relative path url when checksum file and file isn't at same level.

ISSUE TYPE

Feature Pull Request

ADDITIONAL INFORMATION

By exemple get_url don't work for download file on Debian repository :

- name:  Download OS tar 
  ansible.builtin.get_url:
    url: 'https://deb.debian.org/debian/dists/bullseye/main/installer-amd64/current/images/netboot/netboot.tar.gz'
    dest: '/srv/tftp/images/netboot.tar.gz'
    checksum: 'sha256:https://deb.debian.org/debian/dists/bullseye/main/installer-amd64/current/images/SHA256SUMS'
    mode: '0644'

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. labels Oct 13, 2023
@ansibot

ansibot commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/get_url.py:569:72: E241: multiple spaces after ','

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 13, 2023
@anmorel
anmorel marked this pull request as draft October 17, 2023 10:02
@anmorel
anmorel marked this pull request as ready for review October 17, 2023 10:02
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 17, 2023
bcoca
bcoca requested changes Oct 17, 2023
View reviewed changes

@bcoca bcoca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs a changelog

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 17, 2023
@bcoca
bcoca requested a review from sivel October 17, 2023 15:55
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 18, 2023
bcoca
bcoca previously approved these changes Oct 18, 2023
View reviewed changes
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels Oct 18, 2023
@anmorel

anmorel commented Oct 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

Hey @bcoca ,
I have something to do ?

@bcoca

bcoca commented Oct 20, 2023

Copy link
Copy Markdown
Member

@anmorel i just wait for other reviewer

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 26, 2023
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 23, 2024
@anmorel
anmorel requested a review from bcoca April 19, 2024 09:25
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 15, 2025
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Jan 28, 2025
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_pr This PR has not been pushed to for more than one year. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 10, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 24, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Nov 21, 2025
amorel @Akasurde
get_url: Implement relative path in checksumfile
08823a1 
Signed-off-by: amorel <amorel@2302-DES-0003.i-run.si>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
@Akasurde
Akasurde force-pushed the feat_get_url_module_implement_relative_path_in_checksumfile branch from ef0f50e to 08823a1 Compare February 19, 2026 22:17
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 21, 2026
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 28, 2026
@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sivel sivel Awaiting requested review from sivel
@bcoca bcoca Awaiting requested review from bcoca

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feature This issue/PR relates to a feature request. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anmorel @ansibot @bcoca