Add ssh-agent launching, and ssh-agent python client #82181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
feature
Akasurde
reviewed
Nov 9, 2023
ansibot
added
the
needs_revision
ansibot
removed
the
needs_revision
|
FTR, I've started a review draft, will post once I get to completing it.. |
bcoca
reviewed
Nov 15, 2023
| @@ -161,13 +165,59 @@ def __init__(self, loader, sources=None, parse=True, cache=True): | |||
| else: | |||
| self._sources = sources | |||
|
|
|||
| self._launch_ssh_agent() | |||
There was a problem hiding this comment.
I think this belongs does in prefork but not this early, move to strategy? (really in a connection manager as part or execution engine) as inventory does not require connection to the hosts at all. It can provide the info but should not be in charge of setting up communications or their prereqs. The good thing is that this code is easy to move later on, so I do not think it is a blocker for the PR right now.
bcoca
reviewed
Nov 15, 2023
| env: | ||
| - name: ANSIBLE_PRIVATE_KEY | ||
| vars: | ||
| - name: ansible_private_key |
There was a problem hiding this comment.
add ansible_ssh_private_key options with higher precedence than the generic, this way we can reuse for other plugins and still have 'plugin specific' option to override or distinguish
bcoca
reviewed
Nov 15, 2023
| version_added: '2.17' | ||
| private_key_passphrase: | ||
| description: | ||
| - private key passphrase, dependent on ``private_key``. |
There was a problem hiding this comment.
to reinforce, mention it does NOT work with private_key_file
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
sivel
force-pushed
the
ssh_agent
branch
3 times, most recently
from
1667889 to
79ab013
Compare
ansibot
added
ci_verified
This comment was marked as outdated.
This comment was marked as outdated.
ansibot
added
the
stale_ci
ansibot
removed
ci_verified
ansibot
added
the
stale_ci
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
webknjaz
removed
the
needs_revision
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
|
Closing in favor of #84754 where this feature is being completed. |
github-project-automation
bot
moved this from Phase 2 (Dec 16 - Feb 14)
to Done
in ansible-core 2.19
github-project-automation
bot
moved this from 🧐 @webknjaz's review queue 📋
to 🌈 Done 🦄
in 📅 Procrastinating in public
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds:
InventoryManagerto spawn anssh-agentprocess, or re-use an existingssh-agentprocessssh-agentclient for interacting with anssh-agentsocket, for management of keys, as well as locking and unlocking the agentISSUE TYPE
ADDITIONAL INFORMATION
Related: https://datatracker.ietf.org/doc/html/draft-miller-ssh-agent
Notes:
Supersedes #52739.