Fix validating role params of dependencies that are used by ansible-galaxy #82182
Conversation
…alaxy Validate normally if these are documented by the role, but don't require documentation since the role may be unaware of these fields used by ansible-galaxy.
ansibot
added
bug
ansibot
added
ci_verified
|
The test |
| # Since role runtime (with argument spec) requires all role params be documented, | ||
| # add a supplemental spec so this isn't a failure by default for ansible-galaxy options. | ||
| # If the role actually documents these options, they'll be validated normally. | ||
| internal_galaxy_spec = {k: {} for k in VALID_SPEC_KEYS} |
There was a problem hiding this comment.
I would add warning/debug with the skipped keys, for those that are 'overloading' role params and expecting a variable to pass through.
There was a problem hiding this comment.
i just remembered, we did add that warning at one point .. .i'm just not sure where/at what point
There was a problem hiding this comment.
I feel like we'd need to deprecate this dependencies syntax for ansible-galaxy if we want to issue a warning at runtime by default. I could add a debug message in addition to or instead of the vvv message in validate_argument_spec.
ansibot
removed
needs_revision
ansibot
added
the
stale_ci
|
@s-hertel @bcoca checked changes with my error. (valid args) On branch from PR there is no log for (invalid args) If there is any error, it relates to previous role, not current's |
ansibot
added
the
stale_pr
ansibot
added
the
needs_rebase
SUMMARY
Fixes #82154
Validate normally if these are documented by the role, but don't require documentation since the role may be unaware of these fields used by ansible-galaxy.
ISSUE TYPE
ADDITIONAL INFORMATION