expect - hide responses from the invocation with echo=false

[s-hertel]

SUMMARY

Fixes #82188

Modules don't usually sanitize their own invocation this way, so I'm wondering if this be better as a more general feature to hide task invocations.

ISSUE TYPE

• Feature Pull Request

ADDITIONAL INFORMATION

[bcoca]

Modules don't usually sanitize their own invocation this way, so I'm wondering if this be better as a more general feature to hide task invocations.

That is what we have no_log for, but this is one rare case in which the value would be conditional on another option. I can only think of this and pause needing this feature, as it is rare for modules to have to handle interactive input/output.

[s-hertel]

That is what we have no_log for, but this is one rare case in which the value would be conditional on another option.

Making responses a no_log option seems like a better fit than using a module option for this. We decided in triage this approach is fine.

I can only think of this and pause needing this feature, as it is rare for modules to have to handle interactive input/output.

Any module option could be secret, not just related to input/output, and be visible with -vvv unless the option is no_log or the no_log keyword is used. The current solution to #82188 is set no_log on the task, but this obscures the whole task not just the module input.

This won't be an issue for pause specifically, since it's an action plugin and doesn't return the invocation.