move error from display to caller

[bcoca]

done to avoid issues with proxying display calls
fixes #82358

ISSUE TYPE

• Bugfix Pull Request

[sivel]

Since this exposed a potential issue with the strategy, can we also add a try/except around the dmethod call in the processor thread? That way should any other exception happen, it shouldn't cause issues. Would need some warning or at least a debug of the exception that happens in the thread.

[webknjaz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ansibot]

The test ansible-test sanity --test mypy [explain] failed with 1 error:

lib/ansible/utils/display.py:366:16: return-value: Incompatible return value type (got "_Wrapped[[Display, **P], str, [Any, **P], str]", expected "Callable[..., None]")

click here for bot help

[ansibot]

The test ansible-test sanity --test mypy [explain] failed with 1 error:

lib/ansible/utils/display.py:359:65: valid-type: Variable "func" is not valid as a type

click here for bot help

[ansibot]

The test ansible-test sanity --test mypy [explain] failed with 2 errors:

lib/ansible/utils/display.py:363:20: return-value: Incompatible return value type (got "str", expected "Callable[..., None]")
lib/ansible/utils/display.py:364:16: return-value: Incompatible return value type (got "_Wrapped[[Display, **P], str, [Any, **P], Callable[..., None]]", expected "Callable[..., None]")

click here for bot help

[mattclay]

#82358 is no longer an issue in 2.19.