copy - fix recursively setting mode and directory_mode with remote_src=True #82658
+83
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
s-hertel
force-pushed
the
copy-module-fix-recursive-mode
branch
2 times, most recently
from
89b8ac0 to
9f06c32
Compare
ansibot
added
the
needs_revision
ansibot
removed
the
ci_verified
jborean93
removed
the
needs_triage
s-hertel
force-pushed
the
copy-module-fix-recursive-mode
branch
5 times, most recently
from
d6895d0 to
b67aa9f
Compare
ansibot
removed
the
ci_verified
s-hertel
added
the
ci_verified
s-hertel
commented
Feb 15, 2024
s-hertel
commented
Feb 15, 2024
ansibot
removed
the
ci_verified
s-hertel
added
the
ci_verified
ansibot
removed
needs_revision
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
s-hertel
force-pushed
the
copy-module-fix-recursive-mode
branch
from
d943040 to
756c695
Compare
ansibot
removed
needs_rebase
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
Update ``directory_mode`` so it applies to directories in the ``src`` as well as directories created when ``dest`` ends with a trailing slash. Simplify code already handled by module_utils Add test and changelog Fixes ansible#81126
…ait to return for check mode until we know if a change will be made
s-hertel
force-pushed
the
copy-module-fix-recursive-mode
branch
from
756c695 to
a8dc375
Compare
ansibot
added
needs_revision
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #81126
Also simplified the chown_recursive function by walking the path once at most and using the module_utils functions to handle check mode, None values for owner/group/mode/directory_mode, and getting the cumulative changed value.
ISSUE TYPE