Changing validation task to use role's tags - #82953
Closed
sudh33ra wants to merge 1 commit into
Closed
Conversation
ansibot
added
bug
sudh33ra
marked this pull request as draft
April 2, 2024 06:18
sudh33ra
marked this pull request as ready for review
April 2, 2024 06:51
ansibot
added
the
needs_revision
Changing the validation internal task to check for tags on the role itself and use that if they exist, otherwise fallback to always
ansibot
removed
the
needs_revision
ansibot
added
the
stale_ci
sivel
reviewed
Jun 3, 2024
| 'name': task_name, | ||
| 'tags': ['always'], | ||
| # Unless role is specifically tagged, the tag is set to 'always' | ||
| 'tags': ['always'] if not self.tags else self.tags, |
Member
There was a problem hiding this comment.
I think instead of explicitly adding the tags, we should allow inheritance to work like is done with the gather_facts task for plays:
ansible/lib/ansible/executor/play_iterator.py
Lines 164 to 166 in e07b4ed
This would require setting the task ds to a var first, instead of direct returning the dict.
Contributor
|
Thank you for your contribution. I am going to go ahead and close this due to inactivity. Also, there is a new attempt at fixing the issue at #87168. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the validation internal task to check for tags on the role itself and use that if they exist, otherwise fallback to always
SUMMARY
Fixes #82505
ISSUE TYPE