utilize pathlib.Path instead of os.path.join() - #82967
Open
doc-sheet wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
ready_for_review |
nitzmahone
self-requested a review
April 4, 2024 19:20
doc-sheet
force-pushed
the
pathlib_filters
branch
from
May 24, 2025 15:01
7163456 to
83829c0
Compare
Contributor
Author
|
ready_for_review |
Member
|
@doc-sheet It looks like what you want is the - debug:
msg: "{{ 'path/with//extra///slashes////' | normpath }}" |
Contributor
Author
|
Not quite, I don't want to mutate original string more then just clear double slashes But I'll try normpath too, thanks for reminder! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Call
pathlib.Path()instead ofos.path.join()frompath_joinfilter because of better handle of subdirectories.It is now possible to call
{{ path1~'/'~path2 | path_join }}to merge multiple path fragments without need to sanitize occasion slash characters.Result converted to posix path to keep compatibility and old behavior.
e.g.
ISSUE TYPE
ADDITIONAL INFORMATION
Currently to merge multiple path fragments with a nice single delimiter we need to do something like this:
Assuming
app = 'myapp'and subpath anything good to be a path.For example
/var/lib/myapp/dataAfter this change it is safe to write