Skip to content

Fix unable to find pip in the virtualenv when using relative path #83189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yctomwang wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

Fix unable to find pip in the virtualenv when using relative path #83189

yctomwang wants to merge 5 commits into from
+20 −2

Conversation

@yctomwang
Copy link
Contributor

@yctomwang yctomwang commented May 3, 2024

SUMMARY

The bug identified in #81522 was regarding Unable to find pip in the virtualenv when a relative path was fed into chdir. This PR aims to fix this issue along with an integration test to prevent regression.
Fixes #81522

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 3, 2024
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 3, 2024
@mkrizek mkrizek added P3 Priority 3 - Approved, No Time Limitation and removed needs_triage Needs a first human triage before being processed. labels May 14, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 14, 2024
Akasurde
Akasurde requested changes Jan 27, 2025
View reviewed changes
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 27, 2025
@Akasurde Akasurde self-requested a review January 27, 2025 18:16
@Akasurde Akasurde requested a review from mkrizek January 27, 2025 18:16
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 27, 2025
Akasurde
Akasurde reviewed Jan 27, 2025
View reviewed changes
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 27, 2025
@webknjaz
Copy link
Member

webknjaz commented Jan 27, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 27, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 11, 2025
@sdatko sdatko mentioned this pull request Apr 4, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akasurde Akasurde Akasurde approved these changes

@mkrizek mkrizek Awaiting requested review from mkrizek

Assignees

No one assigned

Labels

bug This issue/PR relates to a bug. has_issue module This issue/PR relates to a module. P3 Priority 3 - Approved, No Time Limitation stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pip virtualenv creates chdir twice when using a relative path

5 participants

@yctomwang @webknjaz @Akasurde @mkrizek @ansibot