rpm_key: Added handler for ftp keys#83336
rpm_key: Added handler for ftp keys#83336pvcasillasg wants to merge 12 commits intoansible:develfrom
Conversation
Status code for fetch_url for ftp:// urls is None, this conditional change will allow to rpm_key for ftp urls usage
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
It's the docu ok now? @Akasurde |
|
The test The test |
|
The test |
|
I made several commits, i paste my rpm_key.py file into GitHub, some sanity errors and missed to erase the file:/ check that I used for testing purposes. Please, review it and in the case something more is needed, please, ask for it and I will happy to help @Akasurde @bcoca |
|
@bcoca can you review it? Can't merge since the status is still need_revisions |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
How can I merge it? |


Status code for fetch_url for ftp:// urls is None, this conditional change will allow to rpm_key for ftp urls usage
SUMMARY
Changed the conditional check when fetch a key, since fetch_url function sets a status == None for ftp urls.
fetch_keys uses the function fetch_url to retrieve the target file.
This conditional change will allow to check the url and when the url is ftp, will allow the return code none in order to retrieve the key, without disrupting the http/s retrieves
Fixes #83321
ISSUE TYPE
ADDITIONAL INFORMATION
Issue refer to ansible 2.15, but still persisting in latest