Make apt_repository PPA repos use gpg instead of apt-key #83835
+58
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apt-key has been deprecated, so this has been switched to use gpg instead. Also, the --keyserver option for gpg has also been deprecated, so use of this has also been removed.
ansibot
added
feature
webknjaz
added
the
ci_verified
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
the
needs_revision
ansibot
added
the
needs_ci
ansibot
removed
the
needs_ci
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bcoca
removed
the
needs_triage
ansibot
removed
needs_revision
Contributor
|
@andyfoston When we discussed this in triage today, we came to the consensus that it's probably time to deprecate apt_repository (and apt_key). There is already a good replacement which uses the recommended approach for handling keys, adding the key to the specific repo as opposed to globally. Sorry for not considering this before sending you down a rabbit hole (and thanks for taking an interest in fixing it!). |
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
ansibot
added
the
stale_pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make
apt_repositoryPPA repos use gpg instead of apt-key as this is now deprecated.Also, the
--keyserverGPG option is also deprecated, so this part of the functionality has been replaced with Ansible'sfetch_fileFinally, the GPG key is now pulled from the Ubuntu keyserver over HTTPS instead of HTTP.
ISSUE TYPE
ADDITIONAL INFORMATION
This follows these instructions for adding external repositories