Skip to content

Support terminals that implement truecolor#83911

Open
webknjaz wants to merge 1 commit into
ansible:develfrom
webknjaz:features/truecolor-term-suport
Open

Support terminals that implement truecolor#83911
webknjaz wants to merge 1 commit into
ansible:develfrom
webknjaz:features/truecolor-term-suport

Conversation

@webknjaz

@webknjaz webknjaz commented Sep 6, 2024

Copy link
Copy Markdown
Member
SUMMARY

$sbj. Basically, I want to make my Kitty terminal show invisible debug log lines properly.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
ADDITIONAL INFORMATION

@webknjaz webknjaz self-assigned this Sep 6, 2024
@ansibot ansibot added bug This issue/PR relates to a bug. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. labels Sep 6, 2024
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 10, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 17, 2024
@webknjaz webknjaz force-pushed the features/truecolor-term-suport branch from 05e3fdf to 8638ca9 Compare March 14, 2025 15:50
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 14, 2025
@webknjaz webknjaz force-pushed the features/truecolor-term-suport branch from 8638ca9 to 8be2f68 Compare March 14, 2025 16:22
@webknjaz webknjaz requested a review from mattclay March 14, 2025 16:23
@webknjaz webknjaz marked this pull request as ready for review March 14, 2025 16:23
@webknjaz

Copy link
Copy Markdown
Member Author

@mattclay any suggestions on handling ansible-test better?

@webknjaz webknjaz requested review from bcoca and nitzmahone March 14, 2025 16:24
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 14, 2025

@mattclay mattclay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to terminal support should be merged to ansible-core first. After that, a separate PR can be used to update ansible-test if required.

@webknjaz

Copy link
Copy Markdown
Member Author

@mattclay yeah, I can split the commits. It was just convenient to test it together. I confirmed that both ansible-test changes are needed for this to work there. I was just hoping that you'd be able to find another place to update in case it's somehow possible to patch just one file instead of two..

@webknjaz

Copy link
Copy Markdown
Member Author

@bcoca remind me plz — did you want me to prefix the defaults for COLOR_* in lib/ansible/config/base.yml with smart and process that in ansible.utils.color.parsecolor()? Would this mean that ansible.constants.COLOR_CODES would just get an extra of keys prefixed with smart?

@webknjaz webknjaz moved this from 📑 Ready 👌 to 🫸In review🫷 in 📅 Procrastinating in public 😵‍💫 Mar 14, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 24, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 13, 2025
@webknjaz webknjaz force-pushed the features/truecolor-term-suport branch from 8be2f68 to 415da54 Compare July 23, 2025 23:55
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 23, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug. feature This issue/PR relates to a feature request. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants