Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS notification module added: Plivo #8408

Closed
wants to merge 2 commits into from
Closed

Conversation

rohit01
Copy link

@rohit01 rohit01 commented Aug 2, 2014

Sends SMS notification globally using the Plivo SMS service

Sends SMS notification globally using the Plivo SMS service
@rohit01
Copy link
Author

rohit01 commented Aug 2, 2014

Just started using Ansible few weeks back and find it really awesome. Wrote my first Ansible module and it is well tested. I will upload the examples soon. Let me know, if I missed something in code or documentation.

@mpdehaan
Copy link
Contributor

mpdehaan commented Aug 2, 2014

Thanks very much for the submission. Initially looks good, we have a bit of a submissions queue to get through though I see no problem with this hopping over into the notification modules.

Much appreciated!

@rohit01
Copy link
Author

rohit01 commented Aug 2, 2014

Thanks @mpdehaan. Here's the Ansible playbook example:
https://github.com/rohit01/ansible-plivo-example

(README.md to be updated soon)

@rohit01
Copy link
Author

rohit01 commented Aug 2, 2014

Example docs updated: https://github.com/rohit01/ansible-plivo-example

@rohit01
Copy link
Author

rohit01 commented Sep 2, 2014

Any update on when we are planning to merge this?

@mpdehaan
Copy link
Contributor

Module Repo Information

Hi!

Thanks very much for your interest in Ansible. It sincerely means a lot to us.

On September 26, 2014, due to enormous levels of contribution to the project Ansible decided to reorganize module repos, making it easier
for developers to work on the project and for us to more easily manage new contributions and tickets.

We split modules from the main project off into two repos, http://github.com/ansible/ansible-modules-core and http://github.com/ansible/ansible-modules-extras

If you still would like this pull request merged, we will need your help making this target the new repo. If you do not take any action, this
pull request unfortunately cannot be applied.

We apologize that we are not able to make this transition happen seamlessly, though this is a one-time change and your help is greatly appreciated --
this will greatly improve velocity going forward.

Both sets of modules will ship with Ansible, though they'll receive slightly different ticket handling.

To locate where a module lives between 'core' and 'extras'

Otherwise, if this is a new module:

It may be possible to re-patriate your pull requests automatically, one user-submitted approach for advanced git users
has been suggested at https://gist.github.com/willthames/afbaaab0c9681ed45619

Additionally, should you need more help with this, you can ask questions on:

Thanks you very much!

@mpdehaan mpdehaan closed this Sep 29, 2014
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants