Add v2_playbook_on_terminated_early callback#84093
Open
m-bull wants to merge 6 commits intoansible:develfrom
Open
Add v2_playbook_on_terminated_early callback#84093m-bull wants to merge 6 commits intoansible:develfrom
m-bull wants to merge 6 commits intoansible:develfrom
Conversation
(cherry picked from commit 58355ad)
(cherry picked from commit 32cacd3)
This change adds a new testcase to the ansible-playbook-callbacks integration test that checks the callbacks fired when all hosts fail and we terminate early. This provides a simple regression test for issue 81549. (cherry picked from commit 55ed0b0)
1 task
ansibot
added
needs_triage
ansibot
removed
the
needs_revision
s-hertel
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
ansibot
added
the
stale_pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a callback that fires when terminating because we've run out of hosts to run tasks on.
This is proposed as an alternative approach to #81550, which is discussed in #81549, and is mostly the same solution but an addition rather than a replacement of existing functionality.
Additionally, fix the
v2_playbook_on_no_hosts_remainingfiring twice when usingmax_fail_percentage.