Skip to content

feat: Implement update_url_params#84290

Open
HubertJan wants to merge 2 commits into
ansible:develfrom
HubertJan:HubertJan-update-url-params
Open

feat: Implement update_url_params#84290
HubertJan wants to merge 2 commits into
ansible:develfrom
HubertJan:HubertJan-update-url-params

Conversation

@HubertJan
Copy link
Copy Markdown

@HubertJan HubertJan commented Nov 10, 2024

SUMMARY

Add a utility function update_url_params to modify a URL's query parameters based on a provided dictionary and return the updated URL.

Resolves #84274

ISSUE TYPE
  • Feature Pull Request
ADDITIONAL INFORMATION

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 10, 2024
@ansibot
Copy link
Copy Markdown
Contributor

ansibot commented Nov 10, 2024

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/module_utils/urls.py:1116:76: W291: trailing whitespace
test/units/module_utils/urls/test_Request.py:455:1: W293: blank line contains whitespace
test/units/module_utils/urls/test_Request.py:460:66: W292: no newline at end of file

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

test/units/module_utils/urls/test_Request.py:455:0: trailing-whitespace: Trailing whitespace
test/units/module_utils/urls/test_Request.py:460:0: missing-final-newline: Final newline missing

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 10, 2024
@mkrizek mkrizek added P3 Priority 3 - Approved, No Time Limitation and removed needs_triage Needs a first human triage before being processed. labels Nov 12, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 20, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Dec 11, 2024
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Nov 14, 2025
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees

No one assigned

Labels

feature This issue/PR relates to a feature request. has_issue P3 Priority 3 - Approved, No Time Limitation stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for GET parameters in module_utils.urls.Request

4 participants

@HubertJan @ansibot @Akasurde @mkrizek