playbook tasks restore module k/v for action#84479
Open
bcoca wants to merge 15 commits intoansible:develfrom
Open
playbook tasks restore module k/v for action#84479bcoca wants to merge 15 commits intoansible:develfrom
bcoca wants to merge 15 commits intoansible:develfrom
Conversation
ansibot
added
bug
bcoca
changed the title
ansibot
removed
the
ci_verified
ansibot
added
the
stale_ci
bcoca
force-pushed
the
restore_module_kv
branch
from
fd8fba5 to
e157716
Compare
ansibot
removed
needs_revision
bcoca
force-pushed
the
restore_module_kv
branch
from
e157716 to
a7b371b
Compare
ansibot
added
the
needs_revision
ansibot
removed
the
needs_revision
bcoca
added
data_tagging
and removed
needs_triage
ansibot
added
the
stale_ci
bcoca
force-pushed
the
restore_module_kv
branch
from
7abd62e to
9a8738d
Compare
ansibot
removed
the
stale_ci
bcoca
force-pushed
the
restore_module_kv
branch
from
9a8738d to
14dab00
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bcoca
force-pushed
the
restore_module_kv
branch
from
14dab00 to
fcde06c
Compare
ansibot
removed
the
stale_ci
bcoca
force-pushed
the
restore_module_kv
branch
from
fcde06c to
bc0fed2
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
added
the
needs_revision
webknjaz
reviewed
Apr 16, 2025
| return (action, final_args) | ||
|
|
||
| def _normalize_new_style_args(self, thing, action): | ||
| def _normalize_new_style_args(self, thing: dict[str, t.Any] | str | bytes | None, action: str) -> dict[str, t.Any] | None: |
Member
There was a problem hiding this comment.
There's no bytes. Code below checks for string_types which is always (str,) on Python 3. So just keep str in there. Additionally, EncryptedString is missing.
Finally, it's possible to express some relations between args and the return value through type aliases:
Suggested change
| def _normalize_new_style_args(self, thing: dict[str, t.Any] | str | bytes | None, action: str) -> dict[str, t.Any] | None: | |
| PreParsedArgs: t.TypeAlias = dict[str, t.Any] | |
| def _normalize_new_style_args(self, thing: PreParsedArgs | str | EncryptedString | None, action: str) -> PreParsedArgs | dict[str | t.Literal['_raw_params'], str | t.Any] | dict[t.Literal['_raw_params'], EncryptedString] | None: |
(not tested, it's in-browser coding; move the PreParsedArgs definition to the top level)
webknjaz
reviewed
Apr 16, 2025
| return args | ||
|
|
||
| def _normalize_old_style_args(self, thing): | ||
| def _normalize_old_style_args(self, thing: dict[str, t.Any] | str | bytes | None) -> tuple[str, dict[str, t.Any]]: |
Member
There was a problem hiding this comment.
You can also reuse that type alias here. And there's the same problem with bytes:
Suggested change
| def _normalize_old_style_args(self, thing: dict[str, t.Any] | str | bytes | None) -> tuple[str, dict[str, t.Any]]: | |
| def _normalize_old_style_args(self, thing: PreParsedArgs | str | None) -> tuple[str, PreParsedArgs]: |
webknjaz
reviewed
Apr 16, 2025
| return (action, args) | ||
|
|
||
| def parse(self, skip_action_validation=False): | ||
| def parse(self, skip_action_validation: bool = False) -> tuple[str | None, dict[str, t.Any], str | Sentinel]: |
Member
There was a problem hiding this comment.
nit: this Sentinel thing is sneaky. We should really migrate to a typing-friendly solution that wouldn't accept subclasses...
Suggested change
| def parse(self, skip_action_validation: bool = False) -> tuple[str | None, dict[str, t.Any], str | Sentinel]: | |
| def parse(self, skip_action_validation: bool = False) -> tuple[str | None, PreParsedArgs, str | Sentinel]: |
webknjaz
reviewed
Apr 16, 2025
| def _normalize_parameters(self, thing, action=None, additional_args=None): | ||
| def _normalize_parameters( | ||
| self, | ||
| thing: dict[str, t.Any] | str | bytes, |
Member
There was a problem hiding this comment.
Suggested change
| thing: dict[str, t.Any] | str | bytes, | |
| thing: PreParsedArgs | str, |
webknjaz
reviewed
Apr 16, 2025
| self, | ||
| thing: dict[str, t.Any] | str | bytes, | ||
| action: str | None = None, | ||
| additional_args: str | dict[str, t.Any] | None = None |
Member
There was a problem hiding this comment.
Suggested change
| additional_args: str | dict[str, t.Any] | None = None | |
| additional_args: str | EncryptedString | PreParsedArgs | None = None |
webknjaz
reviewed
Apr 16, 2025
| thing: dict[str, t.Any] | str | bytes, | ||
| action: str | None = None, | ||
| additional_args: str | dict[str, t.Any] | None = None | ||
| ) -> tuple[str, dict[str, t.Any]]: |
Member
There was a problem hiding this comment.
Suggested change
| ) -> tuple[str, dict[str, t.Any]]: | |
| ) -> tuple[str, PreParsedArgs]: |
webknjaz
added
the
ci_verified
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE