Make log severity configurable and consistent between syslog and systemd#84574
Open
andrew-sayers wants to merge 4 commits intoansible:develfrom
Open
Make log severity configurable and consistent between syslog and systemd#84574andrew-sayers wants to merge 4 commits intoansible:develfrom
andrew-sayers wants to merge 4 commits intoansible:develfrom
Conversation
See also ansible/proposals#214 C# EventLogEntryType values do not map neatly to syslog-style severity levels, so this option is ignored in C#.
lib/ansible/module_utils/basic.py sets self._syslog_facility = 'LOG_USER'. 'INFO' is not a valid facility, so this probably never worked as expected.
ansibot
added
feature
s-hertel
removed
the
needs_triage
Author
|
@s-hertel - done. I think this counts as a scope-less change - if not, please let me know what the scope would be. This shouldn't break ansible tasks per se, but could break related scripts for a user who monitors Ansible by e.g. grabbing systemd logs with a missing |
webknjaz
reviewed
Jan 21, 2025
| @@ -0,0 +1,2 @@ | |||
| breaking_changes: | |||
| - Ansible's systemd logs now contain a PRIORITY field (deault value: 5). Downstream programs that inspect Ansible's systemd logs should be updated if they expect the PRIORITY field to be missing (https://github.com/ansible/ansible/pull/84574). | |||
Member
There was a problem hiding this comment.
It's a bit unobvious, but since you have that : in the middle (with a whitespace), the YAML parser makes it a key-value mapping. Here's one way to fix it:
Suggested change
| - Ansible's systemd logs now contain a PRIORITY field (deault value: 5). Downstream programs that inspect Ansible's systemd logs should be updated if they expect the PRIORITY field to be missing (https://github.com/ansible/ansible/pull/84574). | |
| - >- | |
| Ansible's systemd logs now contain a PRIORITY field (deault value: 5). | |
| Downstream programs that inspect Ansible's systemd logs should be updated if | |
| they expect the PRIORITY field to be missing | |
| (https://github.com/ansible/ansible/pull/84574). |
webknjaz
added
the
ci_verified
andrew-sayers
force-pushed
the
log_severity
branch
from
6f72247 to
e471545
Compare
ansibot
added
needs_revision
jborean93
reviewed
Jan 21, 2025
Contributor
jborean93
left a comment
jborean93
left a comment
There was a problem hiding this comment.
From an implementation perspective I'm fine with the changes made to Ansible.Basic.cs
ansibot
removed
the
needs_revision
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
ansibot
added
the
stale_pr
Member
|
@andrew-sayers Could you please rebase this branch? Thanks, |
Akasurde
added
the
needs_info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This builds on a discussion in ansible/proposals#214, and replaces #84504.
syslog messages are currently hardcoded to LOG_INFO, systemd messages have no defined priority.
Add a
TARGET_LOG_SEVERITYoption and use it in both logging frameworks.Ansible log messages are sent through systemd on systems that have the python3
sdnotifypackage installed. This could be deliberate, but in my case, I just happen to have some services that depend on Debian'spython3-sdnotifypackage. Setting a priority for these messages makes it easier to filter them.There is already a
syslog_facilityoption, so it seems natural to add a severity option as part of this job.Note: the final commit in this PR changes the value of
syslog_facilityinparameters.py. Ansible tried to evaluate this assyslog.INFO, failed because there's no such symbol, and fell back toLOG_USER. I've changed the value toLOG_USERin this PR because it's a tangentially related and easy to review at the same time, but the first two commits can be accepted separately if that's better.ISSUE TYPE