Fix collection loader iterator for ext modules - #84758
Merged
Merged
Conversation
ansibot
added
bug
Contributor
|
The test |
ansibot
removed
the
needs_revision
mattclay
reviewed
Mar 5, 2025
ansibot
added
the
needs_revision
webknjaz
reviewed
Mar 6, 2025
Member
|
Plz, rebase to absorb the F41/F40 fix from #84785. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
There's no need to rebase the PR to pick up the fix. Using |
ansibot
removed
needs_revision
Member
Is that different from just restarting the failing job? Because I did that before posting the comment and expected that it'd work the same but it didn't. |
Member
Yes, unlike |
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
jborean93
force-pushed
the
collection-loader-ext
branch
from
September 8, 2025 18:55
68d65a7 to
ab9cfe9
Compare
ansibot
removed
needs_rebase
ansibot
added
the
stale_ci
Fixes the collection loader iter_modules logic to return compiled Python extension modules. This loader is used when attempting to call `pkgutil.iter_modules` on a package that is contained inside the `ansible_collections` path. Before extension modules were skipped which would break imports of 3rd party modules that used compiled extensions if it was installed in a Python environment located inside a collection.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
jborean93
force-pushed
the
collection-loader-ext
branch
from
July 13, 2026 00:05
ab9cfe9 to
b03695d
Compare
ansibot
removed
the
stale_ci
nitzmahone
approved these changes
Jul 14, 2026
nitzmahone
approved these changes
Jul 14, 2026
This was referenced Jul 14, 2026
Contributor
Author
|
Backport PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes the collection loader iter_modules logic to return compiled Python extension modules. This loader is used when attempting to call
pkgutil.iter_moduleson a package that is contained inside theansible_collectionspath. Before extension modules were skipped which would break imports of 3rd party modules that used compiled extensions if it was installed in a Python environment located inside a collection.ISSUE TYPE