Repository navigation
Conversation
1 task done
webknjaz
reviewed
Mar 18, 2025
webknjaz
reviewed
Mar 18, 2025
bcoca
force-pushed
the
fix_extra_raw
branch
2 times, most recently
from
March 26, 2025 16:00
ca68cab to
ee61c4d
Compare
bcoca
marked this pull request as ready for review
April 4, 2025 20:20
mattclay
requested changes
Apr 10, 2025
webknjaz
reviewed
Apr 10, 2025
webknjaz
reviewed
Apr 10, 2025
webknjaz
reviewed
Apr 10, 2025
webknjaz
reviewed
Apr 10, 2025
mattclay
reviewed
Apr 10, 2025
mattclay
requested changes
Apr 10, 2025
| tmp_args = args.pop('args') | ||
| if isinstance(tmp_args, string_types): | ||
| tmp_args = parse_kv(tmp_args) | ||
| tmp_args = parse_kv(tmp_args, check_raw=action in FREEFORM_ACTIONS) |
Member
There was a problem hiding this comment.
What's this change for? I noticed it was in the original commit, along with changelog entries that appear to be related, but those changelog entries were removed in a later commit.
Member
Author
There was a problem hiding this comment.
that should now affect the new parameter, as _raw_params for a module that does not support them should be an error
mattclay
reviewed
Apr 10, 2025
| try: | ||
| if not self.parse_simple_args(term): | ||
| self.parse_kv_args(parse_kv(term)) | ||
| self.parse_kv_args(parse_kv(term, populate_raw_params=False)) |
Member
There was a problem hiding this comment.
Can you add an integration test to verify the error handling for this?
Member
Author
There was a problem hiding this comment.
it seems we would error out later on either way, this just fails faster and slightly changes the message.
Member
Author
|
rethinking this as 2 PRs:
|
bcoca
commented
Apr 14, 2025
| if '_raw_params' in data: | ||
| display.warning(f"Ignoring unparsable data: {data['_raw_params']}") | ||
| del data['_raw_params'] | ||
| if not data: # if only bad args, reset to none to fail below |
Member
Author
There was a problem hiding this comment.
i'm 50/50 on this being a warning vs hard error
This makes it an error if the full string is parsed as 'raw' but a warning if it is only a partial remainder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #84756
ISSUE TYPE