Skip to content

handle collection resources with nesting#84942

Draft
bcoca wants to merge 4 commits into
ansible:develfrom
bcoca:nested
Draft

handle collection resources with nesting#84942
bcoca wants to merge 4 commits into
ansible:develfrom
bcoca:nested

Conversation

@bcoca

@bcoca bcoca commented Apr 8, 2025

Copy link
Copy Markdown
Member

also add some info for debugging
related to #84930

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 8, 2025
@ansible ansible deleted a comment from ansibot Apr 8, 2025
@ansible ansible deleted a comment from ansibot Apr 8, 2025
@ansible ansible deleted a comment from ansibot Apr 8, 2025
@ansible ansible deleted a comment from ansibot Apr 8, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@ansible ansible deleted a comment from ansibot Apr 9, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Apr 10, 2025
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Apr 10, 2025
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 14, 2025
@ansibot

ansibot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

The test ansible-test sanity --test import --python 3.10 [explain] failed with 4 errors:

lib/ansible/utils/collection_loader/__init__.py:72:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_config.py:0:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_finder.py:27:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_meta.py:0:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)

The test ansible-test sanity --test import --python 3.8 [explain] failed with 4 errors:

lib/ansible/utils/collection_loader/__init__.py:72:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_config.py:0:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_finder.py:27:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_meta.py:0:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)

The test ansible-test sanity --test import --python 3.9 [explain] failed with 4 errors:

lib/ansible/utils/collection_loader/__init__.py:72:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_config.py:0:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_finder.py:27:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)
lib/ansible/utils/collection_loader/_collection_meta.py:0:0: traceback: ModuleNotFoundError: No module named 'jinja2' (at lib/ansible/config/manager.py:17:0)

The test ansible-test sanity --test mypy [explain] failed with the error:

Command "/root/.ansible/test/venv/sanity.mypy/3.13/2f0e465a/bin/python /root/ansible/test/sanity/code-smell/mypy.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/mypy.py", line 160, in test_context
    completed_process = subprocess.run(cmd, env=env, capture_output=True, check=True, text=True)
  File "/usr/lib/python3.13/subprocess.py", line 579, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/root/.ansible/test/venv/sanity.mypy/3.13/2f0e465a/bin/python', '-m', 'mypy', '--show-column-numbers', '--show-error-codes', '--no-error-summary', '--allow-redefinition', '--follow-imports', 'normal', '--no-incremental', '--cache-dir', '/dev/null', '--platform', 'linux', '--python-executable', '/root/.ansible/test/venv/sanity.mypy/3.13/2f0e465a/bin/python', '--python-version', '3.9', '--config-file', PosixPath('/root/ansible/test/sanity/code-smell/mypy/ansible-test.ini'), 'test/lib/ansible_test/_util/target/__init__.py', 'test/lib/ansible_test/_util/target/cli/ansible_test_cli_stub.py', 'test/lib/ansible_test/_util/target/common/constants.py', 'test/lib/ansible_test/_util/target/injector/python.py', 'test/lib/ansible_test/_util/target/pytest/plugins/ansible_forked.py', 'test/lib/ansible_test/_util/target/pytest/plugins/ansible_pytest_collections.py', 'test/lib/ansible_test/_util/target/pytest/plugins/ansible_pytest_coverage.py', 'test/lib/ansible_test/_util/target/sanity/compile/compile.py', 'test/lib/ansible_test/_util/target/sanity/import/importer.py', 'test/lib/ansible_test/_util/target/setup/probe_cgroups.py', 'test/lib/ansible_test/_util/target/setup/quiet_pip.py', 'test/lib/ansible_test/_util/target/setup/requirements.py', 'test/lib/ansible_test/_util/target/tools/virtualenvcheck.py', 'test/lib/ansible_test/_util/target/tools/yamlcheck.py']' returned non-zero exit status 2.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/mypy.py", line 233, in <module>
    main()
    ~~~~^^
  File "/root/ansible/test/sanity/code-smell/mypy.py", line 52, in main
    unfiltered_messages.extend(test_context(python_version, context, paths))
                               ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/ansible/test/sanity/code-smell/mypy.py", line 167, in test_context
    raise Exception(f'{ex.stdout=} {ex.stderr=} {ex.returncode=}') from ex
Exception: ex.stdout='lib/ansible/_internal/_errors/_handler.py:85:9: error: Pattern matching is only supported in Python 3.10 and greater  [syntax]\n' ex.stderr='' ex.returncode=2

The test ansible-test sanity --test runtime-metadata [explain] failed with the error:

Command "/root/.ansible/test/venv/sanity.runtime-metadata/3.13/384cba8e/bin/python /root/ansible/test/lib/ansible_test/_util/controller/sanity/code-smell/runtime-metadata.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/lib/ansible_test/_util/controller/sanity/code-smell/runtime-metadata.py", line 21, in <module>
    from ansible.utils.collection_loader import AnsibleCollectionRef
  File "/root/ansible/lib/ansible/utils/collection_loader/__init__.py", line 72, in <module>
    from ._collection_finder import AnsibleCollectionRef
  File "/root/ansible/lib/ansible/utils/collection_loader/_collection_finder.py", line 27, in <module>
    from ansible.utils.display import Display
  File "/root/ansible/lib/ansible/utils/display.py", line 52, in <module>
    from ansible import constants as C
  File "/root/ansible/lib/ansible/constants.py", line 11, in <module>
    from ansible.config.manager import ConfigManager
  File "/root/ansible/lib/ansible/config/manager.py", line 17, in <module>
    from jinja2.nativetypes import NativeEnvironment
ModuleNotFoundError: No module named 'jinja2'

click here for bot help

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Apr 15, 2025
@ansible ansible deleted a comment from ansibot Apr 18, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 25, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jun 11, 2025
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants