allow known_hosts module auto-create the default ~/.ssh dir#85050
Open
Oliver246 wants to merge 6 commits into
Open
allow known_hosts module auto-create the default ~/.ssh dir#85050Oliver246 wants to merge 6 commits into
Oliver246 wants to merge 6 commits into
Conversation
ansibot
added
feature
Contributor
|
The test The test The test |
ansibot
removed
the
needs_revision
mkrizek
added
P3
s-hertel
reviewed
Apr 29, 2025
s-hertel
left a comment
s-hertel
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, just had a couple suggestions about the code and tests.
Please also add the line destructive to test/integration/targets/known_hosts/aliases since that it's no longer contained to the temporary test directory.
…tion test case chmod after mkdir to ensure platform compatibility and integration te…
Author
|
@s-hertel Updated. |
s-hertel
reviewed
May 1, 2025
Author
|
@s-hertel Updated. |
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
ansibot
added
the
stale_pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
84952
ISSUE TYPE