Skip to content

Evaluate possible jinja expression for play vars_files. - #85052

Draft
mehulmistry-accelya wants to merge 20 commits into
ansible:develfrom
mehulmistry-accelya:vars-files-fix
Draft

Evaluate possible jinja expression for play vars_files.#85052
mehulmistry-accelya wants to merge 20 commits into
ansible:develfrom
mehulmistry-accelya:vars-files-fix

Conversation

@mehulmistry-accelya

Copy link
Copy Markdown
SUMMARY

Fixes #85051

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html has_issue labels Apr 28, 2025
nitzmahone and others added 18 commits April 28, 2025 15:55
Co-authored-by: Matt Davis <mrd@redhat.com>
Co-authored-by: Matt Clay <matt@mystile.com>
…ion and (sub-)return value descriptions (ansible#84690)

* Fix initial indent for descriptions of suboptions.
* Fix line width for initial line of option descriptions.
* Use `_UNSET` instead of allowing `ellipsis`

* Fix deprecation warning pre-check

* Deprecation warnings from modules can now be disabled.
* Deprecation warnings from modules get the "can be disabled" notice.

* Include help text in pre-display fatal errors

* Simplify lookup warning/debug messaging

* Fix return type of `timedout` test plugin

* Use `object` for `_UNSET`

* Remove obsolete `convert_data` tests

* Remove unnecessary template from test

* Improve legacy YAML objects backward compat

* Fix templar backward compat for None overrides
* Add help_text to play_hosts deprecation

* clean up TaskResult type handling
* Fix test_range_templating on 32-bit architectures

32-bit archtectures like i386, armel, armhf will fail with the error

ansible._internal._templating._errors.AnsibleTemplatePluginRuntimeError: The
filter plugin 'ansible.builtin.random' failed: Python int too large to convert
to C ssize_t

So just pick sys.maxsize (2**31 - 1) so it works on 32 bit machines.

---------

Co-authored-by: Lee Garrett <lgarrett@rocketjump.eu>
Co-authored-by: Matt Clay <matt@mystile.com>
use existing to avoid deprecation cycle
normalize test too
…le#84984)

Co-authored-by: Matt Clay <matt@mystile.com>
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
)

* Implement TaskResult backward compatibility for callbacks
* general API cleanup
* misc deprecations

Co-authored-by: Matt Clay <matt@mystile.com>

* fix v2_on_any deprecation exclusion for base

---------

Co-authored-by: Matt Clay <matt@mystile.com>
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Apr 28, 2025
@ansibot

ansibot commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

test/units/vars/test_variable_manager.py:125:30: E201: whitespace after '['
test/units/vars/test_variable_manager.py:125:39: E202: whitespace before ']'
test/units/vars/test_variable_manager.py:129:50: E201: whitespace after '['
test/units/vars/test_variable_manager.py:129:74: E202: whitespace before ']'

click here for bot help

@mehulmistry-accelya
mehulmistry-accelya marked this pull request as draft April 28, 2025 14:25
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Apr 28, 2025
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 29, 2025
@mehulmistry-accelya mehulmistry-accelya changed the title Evaluate possible jinja expressions in play vars_files list. Evaluate possible jinja expressions in play vars_files. Apr 30, 2025
@mehulmistry-accelya mehulmistry-accelya changed the title Evaluate possible jinja expressions in play vars_files. Evaluate possible jinja expression for play vars_files. Apr 30, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 7, 2025
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

play fails when vars_files is a jinja expression

10 participants