Adding sslverifystatus flag#85054
Open
JilvinAbraham wants to merge 6 commits into
Open
Conversation
ansibot
added
feature
Added missing comma
updated version from 2.15 to 2.19
version added
removed default
added version
bcoca
reviewed
Apr 29, 2025
| type: bool | ||
| default: "yes" | ||
| version_added: "2.13" | ||
| sslverifystatus: |
Member
There was a problem hiding this comment.
if we are going to add such an option, I would name it nvmd, that already exists and this is just modifying a subset of that. I would include OSP validation in the existing functionality, not as it's own optionvalidate_certs as we do in most other modules
Author
There was a problem hiding this comment.
do u want me to make it a sub option of sslverify itself
Maybe something like the following?
sslverify=dict(
type='dict',
options=dict(
enabled=dict(type='bool', default=True),
verifystatus=dict(type='bool', default=False)
)
mkrizek
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes: #85047
ISSUE TYPE