fix: change the BOOT_TIME_COMMAND for macOS to get higher time precision - #85537
Open
renzibei wants to merge 3 commits into
Open
fix: change the BOOT_TIME_COMMAND for macOS to get higher time precision#85537renzibei wants to merge 3 commits into
renzibei wants to merge 3 commits into
Conversation
ansibot
added
bug
Akasurde
reviewed
Jul 24, 2025
renzibei
added a commit
to renzibei/ansible
that referenced
this pull request
Jul 24, 2025
1 task
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
Member
|
@renzibei We are waiting for the Core team triage and will discuss this issue in that meeting. Will update the discussion here. |
ansibot
added
the
stale_ci
bcoca
requested changes
Aug 7, 2025
bcoca
left a comment
bcoca
left a comment
Member
There was a problem hiding this comment.
I would add a test to ensure we don't regress
ansibot
added
the
needs_revision
* Use `/usr/sbin/sysctl kern.boottime` to replace the `who -b` for the BOOT_TIME_COMMAND of macOS
Akasurde
force-pushed
the
fix/macos_reboot
branch
from
April 16, 2026 18:50
cd3bdad to
ad67575
Compare
ansibot
added
stale_review
Akasurde
approved these changes
Apr 16, 2026
ansibot
added
needs_revision
ansibot
added
the
stale_ci
Member
|
@bcoca do you have a specific test in mind, beyond adjusting the existing one? |
Contributor
|
The macOS remote reboots so quickly (~15 seconds; at least 30 seconds faster than last time I checked), so I can reproduce the issue now just by running - name: Reboot yet again in quick succession
reboot:
when: ansible_facts.os_family == "Darwin"Not sure there's a good way to guarantee integration coverage though, since it only occurs if two reboots occur within a minute. |
s-hertel
approved these changes
May 18, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
pending_ci
and removed
stale_ci
ansibot
added
the
stale_ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix the issue #85070 "macOS boot time command incorrectly checks boot time if last reboot was at same minute".
Use
/usr/sbin/sysctl kern.boottimeto replace thewho -bfor the BOOT_TIME_COMMAND of macOS, to get higher time precision.ISSUE TYPE