Skip to content

cli tools: add ability to set environment keyword - #85890

Open
bcoca wants to merge 1 commit into
ansible:develfrom
bcoca:env_cli
Open

cli tools: add ability to set environment keyword#85890
bcoca wants to merge 1 commit into
ansible:develfrom
bcoca:env_cli

Conversation

@bcoca

@bcoca bcoca commented Sep 22, 2025

Copy link
Copy Markdown
Member

Adds -E|--environment to Ansible CLI tools that run tasks.

Replaces #85376

ISSUE TYPE
  • Feature Pull Request

@bcoca bcoca mentioned this pull request Sep 22, 2025
Closed
@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. labels Sep 22, 2025
@sivel
sivel requested a review from nitzmahone September 22, 2025 19:37
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 22, 2025
nitzmahone
nitzmahone requested changes Sep 23, 2025
View reviewed changes

@nitzmahone nitzmahone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt's got a bunch of other feedback from actually running the code, this was just from inspection of the proposed changes.

Comment thread lib/ansible/config/base.yml Outdated
Comment thread changelogs/fragments/environment_cli.yml Outdated
mattclay
mattclay requested changes Sep 23, 2025
View reviewed changes
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/config/base.yml
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
Comment thread lib/ansible/cli/pull.py Outdated
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Sep 23, 2025
@ansible ansible deleted a comment from ansibot Sep 23, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Sep 23, 2025
webknjaz
webknjaz reviewed Sep 23, 2025
View reviewed changes
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 23, 2025
webknjaz
webknjaz reviewed Sep 24, 2025
View reviewed changes
Comment thread lib/ansible/cli/arguments/option_helpers.py Outdated
webknjaz
webknjaz reviewed Sep 24, 2025
View reviewed changes
Comment thread lib/ansible/cli/pull.py Outdated
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Sep 24, 2025
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 24, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Sep 25, 2025
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 25, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Sep 29, 2025
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 30, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 10, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Dec 19, 2025
@gundalow

gundalow commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@bcoca Hi, the z/OS team were wondering how this is going, and if there is anything we can help with.

@bcoca

bcoca commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

@gundalow waiting on decisions from above

@ansibot

ansibot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@bcoca All commits must have verified signatures.

Please see this Ansible Forum post for more information.

click here for bot help

@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 29, 2026
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 29, 2026
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Apr 30, 2026
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 14, 2026
Amit Ranjan @ketankelkar
@amit-ranjan-9 @nitzmahone @webknjaz @bcoca
adhoc.py updated for -E support
9bfd27e 
simplified implementation

 - removed envfile feature
 - added to run_tasks, no need for new option
 - simpler parser
 - now prepends into play environment keyword, inheritance does rest

Co-authored-by: Ketan Kelkar <ktnklkr@gmail.com>
Co-authored-by: Amit Ranjan <amitranjan.hello@gmail.com>
Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz left review comments
@mattclay mattclay mattclay requested changes
@nitzmahone nitzmahone nitzmahone requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_review Updates were made after the last review and the last review is more than 7 days old.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bcoca @gundalow @ansibot @webknjaz @mattclay @nitzmahone @mkrizek