Fix unarchive file metadata setting - #85917
Open
pkingstonxyz wants to merge 13 commits into
Open
pkingstonxyz wants to merge 13 commits into
pkingstonxyz wants to merge 13 commits into
Conversation
pkingstonxyz
changed the title
ansibot
added
bug
pkingstonxyz
commented
Sep 25, 2025
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
the
needs_revision
1 task
ansibot
removed
the
needs_revision
mkrizek
added
P3
s-hertel
reviewed
Oct 1, 2025
s-hertel
left a comment
s-hertel
left a comment
Contributor
There was a problem hiding this comment.
I think this is a good change.
s-hertel
previously approved these changes
Oct 8, 2025
s-hertel
reviewed
Oct 10, 2025
ansibot
added
the
stale_review
ansibot
added
the
stale_ci
pkingstonxyz
force-pushed
the
fix-unarchive-become-85815
branch
from
February 9, 2026 15:48
dd55c64 to
ccee557
Compare
ansibot
added
needs_ci
pkingstonxyz
marked this pull request as draft
February 9, 2026 17:58
pkingstonxyz
marked this pull request as ready for review
February 9, 2026 17:58
ansibot
added
pending_ci
and removed
needs_ci
ansibot
added
the
stale_ci
pkingstonxyz
force-pushed
the
fix-unarchive-become-85815
branch
from
March 30, 2026 21:51
ea21b0a to
0e0aa23
Compare
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
pkingstonxyz
force-pushed
the
fix-unarchive-become-85815
branch
from
May 1, 2026 20:38
0e0aa23 to
274755c
Compare
ansibot
added
needs_revision
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
needs_ci
pkingstonxyz
removed
needs_revision
ansibot
added
the
stale_ci
ansibot
removed
the
stale_review
This fixes the ownership issue by expanding the scope of the folders being checked. Orignally there was a pass that owned all of the files and then a pass that owned top level directories. This expands the second path to most directories
Creates a new property that returns all of the files created by the archive instead of the files included in the archive (subtle difference).
The check was added because I erroneoulsy thought that setting a dict key would change the order. This is not the case.
set_fs_attributes_if_different already catches OSError.
It was cached, now it's not
pkingstonxyz
force-pushed
the
fix-unarchive-become-85815
branch
from
July 22, 2026 19:07
b686721 to
360c052
Compare
ansibot
added
stale_review
ansibot
added
the
stale_ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Because archives can contain files without containing their parent directories, module
unarchivedoes not set file metadata for implicitly created folders. This PR expandsthe fix in #73024 from fixing just the metadata of top-level files to all created files
or directories.
Fixes #85815
ISSUE TYPE
Bugfix Pull Request