Move apt sources lists aside more comprehensively - #86050
Open
cjwatson wants to merge 1 commit into
Open
Conversation
apt sources may be defined in any of `/etc/apt/sources.list`, `/etc/apt/sources.list.d/*.list`, or `/etc/apt/sources.list.d/*.sources`. When disabling system repositories, move all of these aside rather than only `/etc/apt/sources.list`. This fixes integration test failures in certain corner cases in Debian's CI environment: when testing reverse-dependencies, we use a testbed with most packages from the testing suite but some packages pinned from unstable. The latter are currently set up using `/etc/apt/sources.list.d/*.list`, and as a result the `apt` integration tests accidentally upgraded the testbed to unstable in the middle of the test run, causing confusion in later tests.
ansibot
added
test
s-hertel
added
needs_verified
ansibot
added
the
stale_ci
Contributor
|
@cjwatson Can you rebase your patch on devel? Can we get this patch merged? It helps us in Debian downstream, and is also useful for other Debian-based distros running the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
apt sources may be defined in any of
/etc/apt/sources.list,/etc/apt/sources.list.d/*.list, or/etc/apt/sources.list.d/*.sources. When disabling system repositories, move all of these aside rather than only/etc/apt/sources.list.This fixes integration test failures in certain corner cases in Debian's CI environment: when testing reverse-dependencies, we use a testbed with most packages from the testing suite but some packages pinned from unstable. The latter are currently set up using
/etc/apt/sources.list.d/*.list, and as a result theaptintegration tests accidentally upgraded the testbed to unstable in the middle of the test run, causing confusion in later tests.ISSUE TYPE