New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for list of tag values for ec2 plugin #8726

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@codebynumbers

codebynumbers commented Aug 23, 2014

Detects commas in ec2 tags and treats each one as a seperate tag group.
For example if you have tag key of "class" and value of "web, cron", server is is added to tag_class_web and tag_class_cron.

@jimi-c jimi-c added P3 labels Aug 25, 2014

@jimi-c

This comment has been minimized.

Member

jimi-c commented Aug 25, 2014

Possible Duplicated Efforts

Hi!

Thanks very much for your submission to Ansible. It sincerely means a lot to us that you've taken time to contribute.

It looks like the work from this pull request is a duplicate of the following PR:

  • #8676, which also adds the functionality to disable the splitting of tags for backwards-compatibility purposes.

Based on this, we are going to close this PR in favor of the above.

However, we're absolutely always up for discussion. Since this is a really busy project, we don't always see comments on closed tickets, but want to encourage open dialog. You can stop by the development list, and we'd be glad to talk about it - and we might even be persuaded otherwise!

In the future, sometimes starting a discussion on the development list prior to implenting a feature can make getting things included a little easier, but it's not always neccessary.

Thank you once again for this and your interest in Ansible!

@jimi-c jimi-c closed this Aug 25, 2014

@ansibot ansibot added feature and removed feature_pull_request labels Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment