Initial ansible_ssh_proxy support for ssh transport #9122

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
@sivel
Member

sivel commented Sep 24, 2014

This pull request adds functionality to supply a host to use with the SSH ProxyCommand as requested in #8963

Currently this only:

  1. Adds support for the ssh transport
  2. Only accepts an IP or hostname, not the full ProxyCommand (The ProxyCommand utilizes ssh -W)
  3. Only keys off of ansible_ssh_proxy as a "global" var (--extra-vars/vars_files/etc...) or from inventory (group_vars and host_vars included)

@jimi-c jimi-c added P3 labels Sep 26, 2014

@mpdehaan

This comment has been minimized.

Show comment
Hide comment
@mpdehaan

mpdehaan Oct 30, 2014

Contributor

Can you please add docs to this? Need docs with new parameters. Could document next to ansible_ssh_user, etc.

Somewhat bothers me that this appears to take a tuple (does it?) and there might not be guards around that for error handling - but maybe it doesn't. Seems like it would just take the http:// or https:// or whatever string and that could include all the stuff.

Contributor

mpdehaan commented Oct 30, 2014

Can you please add docs to this? Need docs with new parameters. Could document next to ansible_ssh_user, etc.

Somewhat bothers me that this appears to take a tuple (does it?) and there might not be guards around that for error handling - but maybe it doesn't. Seems like it would just take the http:// or https:// or whatever string and that could include all the stuff.

@nitzmahone

This comment has been minimized.

Show comment
Hide comment
@nitzmahone

nitzmahone Oct 30, 2014

Member

I didn't see this PR until Matt mentioned it here today. Should've included "ProxyCommand" in my PR search- I'm just wrapping up a more comprehensive version that includes defaults/envvar/host/play overrides for SSH proxy host, port, user, pass and private_key, as well as the "big hammer" ssh_args if you need to do something weirder.

Member

nitzmahone commented Oct 30, 2014

I didn't see this PR until Matt mentioned it here today. Should've included "ProxyCommand" in my PR search- I'm just wrapping up a more comprehensive version that includes defaults/envvar/host/play overrides for SSH proxy host, port, user, pass and private_key, as well as the "big hammer" ssh_args if you need to do something weirder.

@sivel

This comment has been minimized.

Show comment
Hide comment
@sivel

sivel Oct 30, 2014

Member

I'll add some docs to this PR soon. It probably won't be until next week though.

As for what this accepts, it is just a straight string, that string would by a hostname or IP address or the bastion host. The printf like formatting may look a little strange since I needed literal % signs in there and had to escape them.

Effectively in an inventory file it might look like:

web01.p.example.org ansible_ssh_proxy=bastion.example.org
Member

sivel commented Oct 30, 2014

I'll add some docs to this PR soon. It probably won't be until next week though.

As for what this accepts, it is just a straight string, that string would by a hostname or IP address or the bastion host. The printf like formatting may look a little strange since I needed literal % signs in there and had to escape them.

Effectively in an inventory file it might look like:

web01.p.example.org ansible_ssh_proxy=bastion.example.org
@erewh0n

This comment has been minimized.

Show comment
Hide comment
@erewh0n

erewh0n Oct 31, 2014

Contributor

👍 this is great -- would we be able to provide alternative port and user arguments?

Contributor

erewh0n commented Oct 31, 2014

👍 this is great -- would we be able to provide alternative port and user arguments?

@beberlei

This comment has been minimized.

Show comment
Hide comment
@beberlei

beberlei Mar 2, 2015

+1 on this one, could this be merged any time soon?

beberlei commented Mar 2, 2015

+1 on this one, could this be merged any time soon?

@bcoca bcoca added this to the v2 milestone Mar 3, 2015

@andreimc

This comment has been minimized.

Show comment
Hide comment
@andreimc

andreimc Apr 25, 2015

👍 would be great!!!!

👍 would be great!!!!

@wallies wallies referenced this pull request in Capgemini/Apollo May 27, 2015

Closed

Can't upload serverspecs inside VPC #249

@davidneudorfer

This comment has been minimized.

Show comment
Hide comment
@davidneudorfer

davidneudorfer Jun 1, 2015

+1 We could definitely use this.

+1 We could definitely use this.

@davidstacy

This comment has been minimized.

Show comment
Hide comment

👍

@stevenscg

This comment has been minimized.

Show comment
Hide comment
@stevenscg

stevenscg Jun 14, 2015

I would definitely use this. +1

I would definitely use this. +1

@pikeas

This comment has been minimized.

Show comment
Hide comment

pikeas commented Jun 19, 2015

+1!

@Eronarn

This comment has been minimized.

Show comment
Hide comment
@Eronarn

Eronarn Jul 6, 2015

Contributor

+1

Contributor

Eronarn commented Jul 6, 2015

+1

@jtyr

This comment has been minimized.

Show comment
Hide comment
@jtyr

jtyr Jul 7, 2015

Contributor

+1

Contributor

jtyr commented Jul 7, 2015

+1

@bcoca bcoca added the needs_rebase label Jul 14, 2015

@rgunst

This comment has been minimized.

Show comment
Hide comment

rgunst commented Jul 14, 2015

+1

@amenonsen

This comment has been minimized.

Show comment
Hide comment
@amenonsen

amenonsen Jul 29, 2015

Contributor

#9477 is described as superseding this PR (and it takes a similar approach), so this should be closed. (From discussions elsewhere, nobody is actively working on this, though #9477 is still on @nitzmahone's list for v2.)

Contributor

amenonsen commented Jul 29, 2015

#9477 is described as superseding this PR (and it takes a similar approach), so this should be closed. (From discussions elsewhere, nobody is actively working on this, though #9477 is still on @nitzmahone's list for v2.)

@jimi-c jimi-c modified the milestones: next, v2 Aug 5, 2015

@sivel

This comment has been minimized.

Show comment
Hide comment
@sivel

sivel Oct 1, 2015

Member

Closing this as the functionality is mostly implemented in devel now.

Member

sivel commented Oct 1, 2015

Closing this as the functionality is mostly implemented in devel now.

@sivel sivel closed this Oct 1, 2015

@ansibot ansibot added feature and removed feature_pull_request labels Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment