Skip to content

Conversation

@kurokobo
Copy link
Contributor

@kurokobo kurokobo commented Feb 19, 2024

SUMMARY
  • Add descriptions and examples for Ingress
  • Convert list of CR params into tables
  • Add note for image that will be used in the mesh ingress
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

I don't know if there are any live previews for PR for docs, so here is a full size screenshot of the page that updated by this PR and built locally (thanks to built-in excellent screenshot feature in Chorme 😃):

127 0 0 1_8000_user-guide_advanced-configuration_mesh-ingress html

@fosterseth
Copy link
Member

@kurokobo great PR! I left some minor suggestions

kurokobo and others added 2 commits February 21, 2024 13:13
…vanced-configuration/mesh-ingress.md

Co-authored-by: Seth Foster <fosterseth@users.noreply.github.com>
@kurokobo
Copy link
Contributor Author

kurokobo commented Feb 21, 2024

@fosterseth
Thank you for review on this! I've applyed all your suggestions and commit additional minor fixes. I've also updated screenshot in my OP.
Thank you 😃

@rooftopcellist rooftopcellist merged commit ac682a9 into ansible:devel Feb 21, 2024
@kurokobo kurokobo deleted the meshingress_docs branch February 21, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants