Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder image for sdist creation #83

Closed
shanemcd opened this issue Sep 8, 2017 · 6 comments
Closed

Builder image for sdist creation #83

shanemcd opened this issue Sep 8, 2017 · 6 comments

Comments

@shanemcd
Copy link
Member

shanemcd commented Sep 8, 2017

Summary

After witnessing the majority of issues that people have been experiencing yesterday and today, we should create a builder image that handles the creation of the sdist. Supporting every OS is probably untenable.

We'll want to bind-mount the project root and dump out the artifact(s) in the appropriate location(s).

Additional Information:

Base image should be FROM centos:7 and install the dependencies necessary for creating the sdist to hand off to the other image builds.

@BastienM
Copy link

A better solution would be to have a CI building the images then distribute them via Docker Hub or Quay.

Most the settings that are available could be integrated into the entrypoints to leverage Docker's environment variables in order to opt in/out features or specify options value.

@ghost
Copy link

ghost commented Sep 11, 2017

Yes i agree @BastienM.
Is there a valid reason why there isnt an official Dockerimage available on the hub and just a docker-compose.yaml for the DB etc. ? Would be interesting :)

@geerlingguy
Copy link
Contributor

geerlingguy commented Sep 11, 2017

@Numblesix - there is an image available, but no, it's not official:

curl -O https://raw.githubusercontent.com/geerlingguy/awx-container/master/docker-compose.yml
docker-compose up -d

I'm working on it in this project: https://github.com/geerlingguy/awx-container — for now I hope it's a good stopgap until AWX has a more official prebuilt image.

(And it's two images, corresponding to the two Dockerfiles AWX ships with, awx_web and awx_task).

@ghost
Copy link

ghost commented Sep 11, 2017

@geerlingguy Nice to see that :)
ive you need some help you let me know 👍

@BastienM
Copy link

BastienM commented Sep 11, 2017

@geerlingguy : Had a quick look at your docker-compose, you should probably drop the links for depends_on.
The former has been deprecated since v1.12 or v1.13 (when networking went live).

The rest is looking good :)

@matburt
Copy link
Member

matburt commented Sep 18, 2017

This is done in #104

@matburt matburt closed this as completed Sep 18, 2017
mabashian pushed a commit to mabashian/awx that referenced this issue Jun 28, 2019
vidyanambiar pushed a commit to vidyanambiar/awx that referenced this issue Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants